New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
radare2-cutter: 1.1 -> 1.3 #38877
radare2-cutter: 1.1 -> 1.3 #38877
Conversation
Success on x86_64-linux (full log) Attempted: radare2, radare2-cutter Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: radare2, radare2-cutter Partial log (click to expand)
|
radare2 2.5.0 was done with #38873, sorry was trying to help O:). Trying cutter 1.3 presently, thanks for checking... will report back shortly! |
Quick look says it's good, thanks! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The radare2 version update is already in master, so might want to drop it but might not be a problem when merging.
Bah, seems something is going on re:capstone --sorry if I bungled that. See: #38873 (comment) Can you take a look? I'm okay just bumping to new capstone sha256 although an explanation would be nice but not required... :) |
Success on aarch64-linux (full log) Attempted: radare2, radare2-cutter Partial log (click to expand)
|
.git breaks our hashes
Now radare2 no longer tries to update git. |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: radare2, radare2-cutter Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: radare2, radare2-cutter Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: radare2, radare2-cutter Partial log (click to expand)
|
\o/ thanks |
Motivation for this change
we now have both a new version of cutter and radare2. Are the bugs fixed all now, you had before @dtzWill ?
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)