New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ddclient extraConfig variable #39092
Conversation
The the extraConfig variable is added below the domain variable in the ddclient config file. The domain variable should always be last.
The documentation suggest multiple hosts can be separated in this manner:
I use the configFile approach when the config gets too complicated. I have no issues with this PR. |
@LasseBlaauwbroek please rebase this PR to resolve conflicts. |
Done |
Master looks different already: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/networking/ddclient.nix#L23 |
Yes, but the lines
still need to be exchanged. Because the domains are still expected to go below anything else. |
See #63087 |
Thanks for the contribution! Sorry for not noticing this earlier. |
Motivation for this change
The ddclient has a catch-all extraConfig variable that is added below the domain variable in the config script. However, the domain should always be last in the config. So I've moved it below extraConfig.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)