Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddclient extraConfig variable #39092

Closed
wants to merge 2 commits into from

Conversation

LasseBlaauwbroek
Copy link
Contributor

Motivation for this change

The ddclient has a catch-all extraConfig variable that is added below the domain variable in the config script. However, the domain should always be last in the config. So I've moved it below extraConfig.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The the extraConfig variable is added below the domain variable in the ddclient config file. The domain variable should always be last.
@tomberek
Copy link
Contributor

The documentation suggest multiple hosts can be separated in this manner:

For example:                                                                                                        
  protocol=hammernode1, \                                                                                           
  login=my-hn-login, password=my-hn-password  myhost.hn.org                                                         
  login=my-login, password=my-password  myhost.dyndns.org,my2nd.dyndns.org      
specifies two host definitions.

I use the configFile approach when the config gets too complicated. I have no issues with this PR.

@matthiasbeyer
Copy link
Contributor

@LasseBlaauwbroek please rebase this PR to resolve conflicts.

@LasseBlaauwbroek
Copy link
Contributor Author

Done

@matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer mentioned this pull request Jun 13, 2019
10 tasks
@LasseBlaauwbroek
Copy link
Contributor Author

Yes, but the lines

    ${lib.concatStringsSep "," cfg.domains}
    ${cfg.extraConfig}

still need to be exchanged. Because the domains are still expected to go below anything else.

@matthiasbeyer
Copy link
Contributor

See #63087

@matthewbauer
Copy link
Member

matthewbauer commented Jun 20, 2019

Thanks for the contribution! Sorry for not noticing this earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants