New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minikube: Add the kvm2 driver #39438
Conversation
The docker-machine-kvm driver is considered deprecated should be replaced with the docker-machine-kvm2 driver (which is maintained by the minikube team). See NixOS#34448
8077f3a
to
c24a7f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does minikube work fine with this driver?
sha256 = "1wc2gvmgb59yh0ldm2plvh6s8mvxvysrxp6w75z16ii86jmi3wr6"; | ||
}; | ||
|
||
docker-machine-kvm2 = buildGoPackage rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move out this expression and put it close to the docker-machine-kvm
attribute?
Builds for me, but virtual machine provisioning fails:
commit-ish |
Hmm it worked for me building on 18.03, will check again in a bit... |
unstable here, with sandbox enabled. |
The git dependency fails to build for me. |
Success on x86_64-linux (full log) Attempted: minikube Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: minikube Partial log (click to expand)
|
Hmm, that strange because for me and Hydra a dependency of minikube cannot be build:
This derivation is failing on Hydra https://hydra.nixos.org/build/73254958#tabs-summary. Can you rebase onto master? (note I don't know which nixpkgs commit ofborg is checking out...) |
@flokli I got the same error, which I was able to get around by providing the version explicitly All seems to work after that
|
@nlewo I did rebase on latest nixos-unstable (channels/nixos-unstable), minikube evaluated to @akazakov Passing the version manually works for me. Can you check if passing it automatically works if we patch |
Motivation for this change
The docker-machine-kvm driver is considered deprecated should be replaced with
the docker-machine-kvm2 driver (which is maintained by the minikube team).
See #34448
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)