Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmlbox2d and gcompris: do not fix Qt version to 5.9 [WIP] #39932

Closed
wants to merge 2 commits into from

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented May 3, 2018

Motivation for this change

They both do not work with 5.10.

We wait until gcompris properly supports 5.10. While it launches, a number of graphical artifacts are missing.

Cc @guibou

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@guibou
Copy link
Contributor

guibou commented May 3, 2018

Have you tried to run gcompris ? When I was writing the derivation for it, I had display issues (most of the SVG / sprites) did not appear. But perhaps the version bump of qmlbox2d fixes the issue as well.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gcompris

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcompris

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wcfqnxpj3fdxn2g4ksvcy69i4cs9qv4q-gcompris-0.90
shrinking /nix/store/wcfqnxpj3fdxn2g4ksvcy69i4cs9qv4q-gcompris-0.90/bin/.gcompris-qt-wrapped
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wcfqnxpj3fdxn2g4ksvcy69i4cs9qv4q-gcompris-0.90/bin
patching script interpreter paths in /nix/store/wcfqnxpj3fdxn2g4ksvcy69i4cs9qv4q-gcompris-0.90
checking for references to /build in /nix/store/wcfqnxpj3fdxn2g4ksvcy69i4cs9qv4q-gcompris-0.90...
postPatchMkspecs
postPatchMkspecs

@peterhoeg
Copy link
Member Author

You're right - icons are missing with 5.10. I'll put this on hold for when gcompris is updated.

@guibou
Copy link
Contributor

guibou commented May 4, 2018

Thank you. (Sorry, I should have put a command in the nix file saying why I was using qt 5.9)

@xeji
Copy link
Contributor

xeji commented May 5, 2018

I'll put this on hold for when gcompris is updated.

Marking this as WIP until then.

@peterhoeg peterhoeg changed the title qmlbox2d and gcompris: do not fix Qt version to 5.9 qmlbox2d and gcompris: do not fix Qt version to 5.9 [WIP] May 6, 2018
Also, no longer force the Qt version to 5.9.
A few minor cleanups as well.
@guibou
Copy link
Contributor

guibou commented Dec 20, 2018

I pushed #52567 with gcompris 0.95 which now works with qt > 5.9.

@peterhoeg peterhoeg closed this Dec 20, 2018
@peterhoeg peterhoeg deleted the u/qmlbox branch December 20, 2018 13:57
@peterhoeg peterhoeg restored the u/qmlbox branch December 21, 2018 00:51
@peterhoeg peterhoeg deleted the u/qmlbox branch April 4, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants