zsh: move setEnvironment stuff to zprofile #40223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix #33219 |
jD91mZM2
deleted the
shouldnt-we-just-use-the-pam-environment-file-instead
branch
|
This seems to break non-interactive-, non-login-shells (e.g. ssh): #40759 |
|
we should really just use /etc/environment |
xeji
added a commit
that referenced
this pull request
May 19, 2018
Revert "zsh: move setEnvironment stuff to zprofile" (#40223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.zshenv is always sourced, meaning it'll override all local environment variables with their system defaults.
It'll also make your shell startup 0.0000000000001ms slower.
.zprofile is only sourced for login shells, meaning users who set environment stuff in the .xprofile will get to keep their modifications.
The current xsession script will already source /etc/profile so all envs will still be avaiable from X.
We should probably use /etc/environment instead of a per-shell global default though IMO