New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qiskit: init at 0.4.15 #40395
qiskit: init at 0.4.15 #40395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python package set of libraries in Nixpkgs can have only one version of each package. A library itself can also only depend on the versions provided with python-packages.nix
, and not on any other private versions.
Typically, packages don't need exactly the versions they specify.
description = "A Python library for the Quantum Experience API"; | ||
homepage = https://github.com/QISKit/qiskit-api-py; | ||
license = lib.licenses.apache2; | ||
maintainers = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you maintain this?
sha256 = "480cce2ca285368432b7d00b9cd702a4f8a1c9d69914ba6f65e08099e151e407"; | ||
}; | ||
|
||
buildInputs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
propagatedBuildInputs
description = "A Python module to visualise quantum circuit"; | ||
homepage = https://github.com/nelimeee/qasm2image; | ||
license = lib.licenses.cecill_b; | ||
maintainers = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you maintain this?
]; | ||
|
||
# test doesn't pass | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? Is it something upstream needs to fix? Or should we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests fail because PyPI's QISKit package doesn't contain tests modules.
I updated the description.
@@ -0,0 +1,1965 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is I guess an accident?
@@ -0,0 +1,59 @@ | |||
{ pkgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no pkgs
, only individual packages as parameters
@@ -0,0 +1,59 @@ | |||
{ pkgs | |||
, stdenv | |||
, lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib
is available as stdenv.lib
]; | ||
|
||
# test doesn't pass | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
description = "Quantum Software Development Kit for writing quantum computing experiments, programs, and applications"; | ||
homepage = https://github.com/QISKit/qiskit-sdk-py; | ||
license = lib.licenses.apache2; | ||
maintainers = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you maintain this?
I've just updated |
Removed all private dependencies from QISKit. I'll try to fix test issues. |
|
@FRidh Could you review this PR again? |
colorama | ||
]; | ||
checkPhase = '' | ||
python3 tests/launch_tests.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${python.interpreter}
@FRidh fixed |
@GrahamcOfBorg build python2.pkgs.IBMQuantumExperience python2.pkgs.qiskit python2.pkgs.qasm2image python3.pkgs.IBMQuantumExperience python3.pkgs.qiskit python3.pkgs.qasm2image |
Failure on aarch64-linux (full log) Attempted: python2.pkgs.IBMQuantumExperience, python2.pkgs.qiskit, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.qasm2image Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: python2.pkgs.IBMQuantumExperience, python2.pkgs.qiskit, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.qasm2image Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: python2.pkgs.IBMQuantumExperience, python2.pkgs.qiskit, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.qasm2image Partial log (click to expand)
|
1abeb45
to
a07664c
Compare
@FRidh All build issues should be fixed now. |
@FRidh Why don't you approve? |
@pandaman64 simple, I don't check this page this continuously. |
@GrahamcOfBorg build python2.pkgs.IBMQuantumExperience python2.pkgs.qiskit python2.pkgs.qasm2image python3.pkgs.IBMQuantumExperience python3.pkgs.qiskit python3.pkgs.qasm2image |
Success on x86_64-linux (full log) Attempted: python2.pkgs.IBMQuantumExperience, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.qiskit, python2.pkgs.qasm2image Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.IBMQuantumExperience, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.qiskit, python2.pkgs.qasm2image Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: python2.pkgs.IBMQuantumExperience, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.qiskit, python2.pkgs.qasm2image Partial log (click to expand)
|
cairocffi is still broken:
It seems OpenMP is missing in darwin. I'll add it.
|
ef80081
to
d4e574f
Compare
@FRidh Fixed darwin build issue. Sorry for pinging you a lot. |
@FRidh Could you run the build and approve? |
@GrahamcOfBorg build python2.pkgs.IBMQuantumExperience python2.pkgs.qiskit python2.pkgs.qasm2image python3.pkgs.IBMQuantumExperience python3.pkgs.qiskit python3.pkgs.qasm2image |
Success on x86_64-linux (full log) Attempted: python2.pkgs.IBMQuantumExperience, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.qiskit, python2.pkgs.qasm2image Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python2.pkgs.IBMQuantumExperience, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.qiskit, python2.pkgs.qasm2image Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: python2.pkgs.IBMQuantumExperience, python3.pkgs.IBMQuantumExperience, python3.pkgs.qiskit, python3.pkgs.qasm2image The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.qiskit, python2.pkgs.qasm2image Partial log (click to expand)
|
@FRidh Now this PR is mergeable. Isn't it? |
Thank you so much! |
Motivation for this change
IBMQuantumExperience: init at 1.9.1
qiskit: init at 0.4.15
qasm2image: init at 0.5.0
This pull request introduces several python libraries for creating quantum programs.
IBMQuantumExperience is an API for IBM Q, IBM's quantum processors.
QISKit is an SDK for developing quantum programs with Python.
qasm2image visualizes quantum programs.
QISKit depends on IBMQuantumExperience and qasm2image on QISKit. So I put them in a single pull request.
Some QISKit's dependencies have a different version from the upstream, so I copied their
default.nix
into QISKit's directory and changed to the appropriate versions.I'm not sure this is a good workaround.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)