Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nasm: set -Wno-error=attributes for gcc8 #40431

Merged
merged 1 commit into from May 13, 2018
Merged

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented May 13, 2018

Motivation for this change

It was broken without: https://nix-cache.s3.amazonaws.com/log/q1ll3km6l5crfz1sjb8ixfpwd8v5iq6m-nasm-2.13.03.drv

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nasm

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qp2kna32dyya1r89kj0niqr6adxyfb2f-nasm-2.13.03
shrinking /nix/store/qp2kna32dyya1r89kj0niqr6adxyfb2f-nasm-2.13.03/bin/nasm
shrinking /nix/store/qp2kna32dyya1r89kj0niqr6adxyfb2f-nasm-2.13.03/bin/ndisasm
gzipping man pages under /nix/store/qp2kna32dyya1r89kj0niqr6adxyfb2f-nasm-2.13.03/share/man/
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qp2kna32dyya1r89kj0niqr6adxyfb2f-nasm-2.13.03/bin
patching script interpreter paths in /nix/store/qp2kna32dyya1r89kj0niqr6adxyfb2f-nasm-2.13.03
checking for references to /build in /nix/store/qp2kna32dyya1r89kj0niqr6adxyfb2f-nasm-2.13.03...
/nix/store/qp2kna32dyya1r89kj0niqr6adxyfb2f-nasm-2.13.03

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nasm

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qxgqhv0848nzc7i0n225p4qjcf9kv7lb-nasm-2.13.03
shrinking /nix/store/qxgqhv0848nzc7i0n225p4qjcf9kv7lb-nasm-2.13.03/bin/ndisasm
shrinking /nix/store/qxgqhv0848nzc7i0n225p4qjcf9kv7lb-nasm-2.13.03/bin/nasm
gzipping man pages under /nix/store/qxgqhv0848nzc7i0n225p4qjcf9kv7lb-nasm-2.13.03/share/man/
strip is /nix/store/ks7k1wdljx2knaayzr528cwbj6v970km-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qxgqhv0848nzc7i0n225p4qjcf9kv7lb-nasm-2.13.03/bin
patching script interpreter paths in /nix/store/qxgqhv0848nzc7i0n225p4qjcf9kv7lb-nasm-2.13.03
checking for references to /build in /nix/store/qxgqhv0848nzc7i0n225p4qjcf9kv7lb-nasm-2.13.03...
/nix/store/qxgqhv0848nzc7i0n225p4qjcf9kv7lb-nasm-2.13.03

@xeji xeji merged commit d93b315 into NixOS:gcc8 May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants