electrum and electron-cash: add support for btchip library #40816

nyanloutre · 2018-05-20T13:50:12Z

Motivation for this change

Adding support for Ledger Nano S hardware wallet in electrum by adding a dependency on btchip.

Close #30347 (kudo for @k0001)

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

disassembler · 2018-05-21T11:04:45Z

@GrahamcOfBorg build btchip

GrahamcOfBorg · 2018-05-21T11:05:03Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: btchip

Partial log (click to expand)

Cannot nix-instantiate `btchip' because:
�[31;1merror:�[0m attribute 'btchip' in selection path 'btchip' not found

GrahamcOfBorg · 2018-05-21T11:05:12Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: btchip

Partial log (click to expand)

Cannot nix-instantiate `btchip' because:
�[31;1merror:�[0m attribute 'btchip' in selection path 'btchip' not found

GrahamcOfBorg · 2018-05-21T11:05:25Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: btchip

Partial log (click to expand)

Cannot nix-instantiate `btchip' because:
error: attribute 'btchip' in selection path 'btchip' not found

disassembler · 2018-05-21T11:06:08Z

@GrahamcOfBorg build pythonPackages.btchip

GrahamcOfBorg · 2018-05-21T11:06:22Z

Success on x86_64-linux (full log)

Attempted: pythonPackages.btchip

Partial log (click to expand)

Installing collected packages: btchip-python
Successfully installed btchip-python-0.1.27
/build/btchip-python-0.1.27
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27/lib
patching script interpreter paths in /nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27
checking for references to /build in /nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27...
/nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27

GrahamcOfBorg · 2018-05-21T11:06:48Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.btchip

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

disassembler · 2018-05-21T11:31:51Z

@GrahamcOfBorg build pythonPackages.btchip

GrahamcOfBorg · 2018-05-21T11:32:21Z

Success on x86_64-linux (full log)

Attempted: pythonPackages.btchip

Partial log (click to expand)

Installing collected packages: btchip-python
Successfully installed btchip-python-0.1.27
/build/btchip-python-0.1.27
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27/lib
patching script interpreter paths in /nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27
checking for references to /build in /nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27...
/nix/store/hx7jfmfa3r2v8x3fxwwf9gwjdsg11s47-python2.7-btchip-python-0.1.27

GrahamcOfBorg · 2018-05-21T11:32:22Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.btchip

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-21T12:06:33Z

Failure on aarch64-linux (full log)

Attempted: pythonPackages.btchip

Partial log (click to expand)

                 from /nix/store/6p0715xklf0qr64ia3jqaav47j31ds2j-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/ndarrayobject.h:18,
                 from /nix/store/6p0715xklf0qr64ia3jqaav47j31ds2j-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/arrayobject.h:4,
                 from memoryviewattrs.cpp:580:
/nix/store/6p0715xklf0qr64ia3jqaav47j31ds2j-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
building of '/nix/store/15z1r7l6n9cljw0a0k09sblnx98wq1zq-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/08dn1ysl592ycrqa2pgcd7vz1my0fivs-python2.7-hidapi-0.7.99.post21.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9c4v9p41b2h1z722347bcrnfabqnzbxv-python2.7-btchip-python-0.1.27.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/9c4v9p41b2h1z722347bcrnfabqnzbxv-python2.7-btchip-python-0.1.27.drv' failed

GrahamcOfBorg · 2018-05-21T13:06:36Z

Failure on aarch64-linux (full log)

Attempted: pythonPackages.btchip

Partial log (click to expand)

                 from /nix/store/6p0715xklf0qr64ia3jqaav47j31ds2j-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/ndarrayobject.h:18,
                 from /nix/store/6p0715xklf0qr64ia3jqaav47j31ds2j-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/arrayobject.h:4,
                 from memoryviewattrs.cpp:580:
/nix/store/6p0715xklf0qr64ia3jqaav47j31ds2j-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
building of '/nix/store/15z1r7l6n9cljw0a0k09sblnx98wq1zq-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/08dn1ysl592ycrqa2pgcd7vz1my0fivs-python2.7-hidapi-0.7.99.post21.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9c4v9p41b2h1z722347bcrnfabqnzbxv-python2.7-btchip-python-0.1.27.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/9c4v9p41b2h1z722347bcrnfabqnzbxv-python2.7-btchip-python-0.1.27.drv' failed

disassembler · 2018-05-21T15:26:27Z

See Failure above. This needs resolved before we can merge.

nyanloutre · 2018-05-21T17:31:17Z

Seems to be a timeout problem with the aarch64 build machine on long builds.

The error here come from the Cython package that the aarch64 machine is not able to compile in time : https://hydra.nixos.org/build/72894188

disassembler · 2018-05-23T16:14:55Z

@GrahamcOfBorg build pythonPackages.btchip

GrahamcOfBorg · 2018-05-23T16:15:18Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.btchip

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-23T16:15:40Z

Success on x86_64-linux (full log)

Attempted: pythonPackages.btchip

Partial log (click to expand)

Installing collected packages: btchip-python
Successfully installed btchip-python-0.1.27
/build/btchip-python-0.1.27
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ah9vd541hwrbbaykz2aks8i60k149wmd-python2.7-btchip-python-0.1.27
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ah9vd541hwrbbaykz2aks8i60k149wmd-python2.7-btchip-python-0.1.27/lib
patching script interpreter paths in /nix/store/ah9vd541hwrbbaykz2aks8i60k149wmd-python2.7-btchip-python-0.1.27
checking for references to /build in /nix/store/ah9vd541hwrbbaykz2aks8i60k149wmd-python2.7-btchip-python-0.1.27...
/nix/store/ah9vd541hwrbbaykz2aks8i60k149wmd-python2.7-btchip-python-0.1.27

GrahamcOfBorg · 2018-05-23T17:18:30Z

Failure on aarch64-linux (full log)

Attempted: pythonPackages.btchip

Partial log (click to expand)

   char *__pyx_v_a_2d_char_ptr_array[10][20];
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cvardef.cpp:1074:10: warning: variable ‘__pyx_v_a_2d_char_ptr_ptr_array’ set but not used [-Wunused-but-set-variable]
   char **__pyx_v_a_2d_char_ptr_ptr_array[10][20];
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
==============================
building of '/nix/store/xpg1zk3gwmlapnsvlmvw3p3zizs7c3ky-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/mihrcbgm4prc9gw1xxkr4hh6jh6fhfc8-python2.7-hidapi-0.7.99.post21.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/aql3hc2rgsvxa8jhap5lmv0k0nsn98h3-python2.7-btchip-python-0.1.27.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/aql3hc2rgsvxa8jhap5lmv0k0nsn98h3-python2.7-btchip-python-0.1.27.drv' failed

nyanloutre · 2018-06-27T08:44:40Z

@GrahamcOfBorg build pythonPackages.btchip

nyanloutre · 2018-09-05T19:34:17Z

Waiting on #45644

nyanloutre · 2018-09-12T15:31:16Z

@disassembler it should build now 🎉

disassembler · 2018-09-27T17:37:01Z

@GrahamcOfBorg build pythonPackages.btchip

GrahamcOfBorg · 2018-09-27T17:37:37Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.btchip

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-27T17:37:47Z

Success on aarch64-linux (full log)

Attempted: pythonPackages.btchip

Partial log (click to expand)

Installing collected packages: btchip-python
Successfully installed btchip-python-0.1.28
/build/btchip-python-0.1.28
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2ywmhw6xgmfgkvfnlf6pw75dmw1m3d98-python2.7-btchip-python-0.1.28
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2ywmhw6xgmfgkvfnlf6pw75dmw1m3d98-python2.7-btchip-python-0.1.28/lib
patching script interpreter paths in /nix/store/2ywmhw6xgmfgkvfnlf6pw75dmw1m3d98-python2.7-btchip-python-0.1.28
checking for references to /build in /nix/store/2ywmhw6xgmfgkvfnlf6pw75dmw1m3d98-python2.7-btchip-python-0.1.28...
/nix/store/2ywmhw6xgmfgkvfnlf6pw75dmw1m3d98-python2.7-btchip-python-0.1.28

GrahamcOfBorg · 2018-09-27T17:37:54Z

Success on x86_64-linux (full log)

Attempted: pythonPackages.btchip

Partial log (click to expand)

Installing collected packages: btchip-python
Successfully installed btchip-python-0.1.28
/build/btchip-python-0.1.28
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/779g4663zykwj7ifbrmiycp0bqw3izwa-python2.7-btchip-python-0.1.28
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/779g4663zykwj7ifbrmiycp0bqw3izwa-python2.7-btchip-python-0.1.28/lib
patching script interpreter paths in /nix/store/779g4663zykwj7ifbrmiycp0bqw3izwa-python2.7-btchip-python-0.1.28
checking for references to /build in /nix/store/779g4663zykwj7ifbrmiycp0bqw3izwa-python2.7-btchip-python-0.1.28...
/nix/store/779g4663zykwj7ifbrmiycp0bqw3izwa-python2.7-btchip-python-0.1.28

nyanloutre · 2018-09-29T07:53:56Z

@disassembler it seems to have build successfully

disassembler · 2018-10-01T22:13:35Z

Merged! Thanks for the contribution!

nyanloutre · 2018-10-01T22:14:30Z

Thanks for your time !

nyanloutre requested a review from FRidh as a code owner May 20, 2018 13:50

nyanloutre changed the title ~~Btchip electrum~~ electrum: add support for btchip library May 20, 2018

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels May 20, 2018

nyanloutre changed the title ~~electrum: add support for btchip library~~ electrum and electron-cash: add support for btchip library May 21, 2018

nyanloutre force-pushed the btchip-electrum branch from 0c73f27 to 9af51a8 Compare May 21, 2018 11:24

nyanloutre force-pushed the btchip-electrum branch from 9af51a8 to da9428e Compare July 7, 2018 14:36

nyanloutre force-pushed the btchip-electrum branch from da9428e to 5d7326d Compare September 5, 2018 19:32

nyanloutre force-pushed the btchip-electrum branch from 5d7326d to d21ff6b Compare September 12, 2018 15:30

k0001 and others added 7 commits September 30, 2018 11:04

electrum: add support for LedgerHQ hardware wallet

a4a2168

btchip: fix license name

d9609ee

btchip: Python modules as propagatedBuildInputs

f00dc14

btchip: Disable checks because of hardware requirements

2ab747b

btchip: 0.1.21 -> 0.1.27

2173f75

electron-cash: add support for LedgerHQ hardware wallet

9c74229

btchip: 0.1.27 -> 0.1.28

8d742a3

nyanloutre force-pushed the btchip-electrum branch from d21ff6b to 8d742a3 Compare September 30, 2018 09:08

disassembler approved these changes Oct 1, 2018

View reviewed changes

disassembler merged commit 483e2a1 into NixOS:master Oct 1, 2018

nyanloutre deleted the btchip-electrum branch October 2, 2018 07:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

electrum and electron-cash: add support for btchip library #40816

electrum and electron-cash: add support for btchip library #40816

nyanloutre commented May 20, 2018 •

edited

disassembler commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

disassembler commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

disassembler commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

disassembler commented May 21, 2018

nyanloutre commented May 21, 2018

disassembler commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

nyanloutre commented Jun 27, 2018

nyanloutre commented Sep 5, 2018

nyanloutre commented Sep 12, 2018

disassembler commented Sep 27, 2018

GrahamcOfBorg commented Sep 27, 2018

GrahamcOfBorg commented Sep 27, 2018

GrahamcOfBorg commented Sep 27, 2018

nyanloutre commented Sep 29, 2018

disassembler commented Oct 1, 2018

nyanloutre commented Oct 1, 2018

electrum and electron-cash: add support for btchip library #40816

electrum and electron-cash: add support for btchip library #40816

Conversation

nyanloutre commented May 20, 2018 • edited

Motivation for this change

Things done

disassembler commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

disassembler commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

disassembler commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

GrahamcOfBorg commented May 21, 2018

disassembler commented May 21, 2018

nyanloutre commented May 21, 2018

disassembler commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

nyanloutre commented Jun 27, 2018

nyanloutre commented Sep 5, 2018

nyanloutre commented Sep 12, 2018

disassembler commented Sep 27, 2018

GrahamcOfBorg commented Sep 27, 2018

GrahamcOfBorg commented Sep 27, 2018

GrahamcOfBorg commented Sep 27, 2018

nyanloutre commented Sep 29, 2018

disassembler commented Oct 1, 2018

nyanloutre commented Oct 1, 2018

nyanloutre commented May 20, 2018 •

edited