New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pykdtree: init at 1.3.0 #41355
Conversation
@GrahamcOfBorg build pythonPackages.pykdtree python3Packages.pykdtree |
Failure on x86_64-darwin (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
looks like this needs |
@xeji Thanks for the review. According to the package documentation we can disable the use of openmp by exporting |
Apparently
But disabling it should also be fine, so let's try that first. @GrahamcOfBorg build pythonPackages.pykdtree python3Packages.pykdtree |
Success on x86_64-linux (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
@xeji Seems like no build was triggered for darwin. |
@Assassinkin it was queued but currently no darwin builder is available (they're run by volunteers and not always up). See https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1 for status. |
@xeji Thanks for the explanation didn't know about that. In the mean time i was able to add openmp as build input by passing it as follow
What do you recommend ? use |
According to upstream https://github.com/storpipfugl/pykdtree#benchmarks , multithreading with |
@xeji included openmp. |
@GrahamcOfBorg build pythonPackages.pykdtree python3Packages.pykdtree |
Success on aarch64-linux (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
Thanks. Let's wait for the Darwin build, I'll merge if it succeeds. |
Failure on x86_64-darwin (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
that was the old build job, we can ignore it. |
Success on x86_64-darwin (full log) Attempted: pythonPackages.pykdtree, python3Packages.pykdtree Partial log (click to expand)
|
* master: (63 commits) tests.cc-wrapper: do not test sanitizers on darwin nodePackages_8_x: Add nodejs (npm) to wrapper python.pkgs.cairocffi: support darwin osinfo-db: 20180514 -> 20180531 (#41532) pkcs11helper: 1.22 -> 1.23 (#41530) pmd: 6.3.0 -> 6.4.0 (#41529) renpy: 6.99.14.3 -> 7.0.0 (#41515) wireless-regdb: 2018.05.09 -> 2018.05.31 (#41502) gnuplot: 5.2.3 -> 5.2.4 (#41505) qrencode: 4.0.0 -> 4.0.1 Revert "libbsd: replace with nbcompat" Revert "opendkim: fix libbsd dependency" Revert "libbsd-freedesktop: re-init at 0.9.1, use for samba" flent: fix fetchFromGitHub version syncthing: 0.14.47 -> 0.14.48 pythonPackages.pykdtree: init at 1.3.0 (#41355) snd: 18.3 -> 18.4 bat: support darwin faust2: fix build with llvm 5.0.2 (#40672) mc: 4.8.20 -> 4.8.21 (#41496) ...
Motivation for this change
pykdtree is a kd-tree implementation for fast nearest neighbour search in Python. The aim is to be the fastest implementation around for common use cases (low dimensions and low number of neighbours) for both tree construction and queries.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)