New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aliases.nix using the wrong self refs. #41810
Fix aliases.nix using the wrong self refs. #41810
Conversation
Given the amount of rebuilds this should go into staging instead? |
Yes. I'm surprised it's that many. |
a355d04
to
c23000d
Compare
@GrahamcOfBorg eval |
c23000d
to
9555fd7
Compare
The mass rebuild seems correct. The difference is that after this PR |
So is this good to merge? |
I was hoping to get a response from @nbp just in case there was a real reason for doing it the original way. Otherwise it looks good though. |
The fact revealed by this PR that
@Ericson2314, could you look into this? |
Motivation for this change
Addresses this comment. For example,
dbus_libs
is frequently depended on instead ofdbus
, so the use ofnoXlibs
(which overridesdbus
to prevent X deps) did not properly change those dependencies.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)