Crystal: 0.24.2 -> 0.25.0 #41834

manveru · 2018-06-11T10:52:43Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-06-11T11:03:02Z

@GrahamcOfBorg build crystal

GrahamcOfBorg · 2018-06-11T11:03:26Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: crystal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-11T11:10:49Z

Success on x86_64-linux (full log)

Attempted: crystal

Partial log (click to expand)

shrinking /nix/store/r4ffxfin754vfr9wqkjh4cyam33kc9hm-crystal-0.25.0/lib/crystal/ext/sigfault.o
wrong ELF type
shrinking /nix/store/r4ffxfin754vfr9wqkjh4cyam33kc9hm-crystal-0.25.0/lib/crystal/llvm/ext/llvm_ext.o
wrong ELF type
gzipping man pages under /nix/store/r4ffxfin754vfr9wqkjh4cyam33kc9hm-crystal-0.25.0/share/man/
patching script interpreter paths in /nix/store/r4ffxfin754vfr9wqkjh4cyam33kc9hm-crystal-0.25.0
checking for references to /build in /nix/store/r4ffxfin754vfr9wqkjh4cyam33kc9hm-crystal-0.25.0...
wrong ELF type
wrong ELF type
/nix/store/r4ffxfin754vfr9wqkjh4cyam33kc9hm-crystal-0.25.0

GrahamcOfBorg · 2018-06-11T11:12:36Z

Success on x86_64-darwin (full log)

Attempted: crystal

Partial log (click to expand)

ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
./bin/crystal build --no-debug --release  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
Using /nix/store/bvrz6gfvmgb620knx2d9nr8kvz4l21i7-llvm-5.0.2/bin/llvm-config [version=5.0.2]
./bin/crystal docs -b https://crystal-lang.org/api/latest src/docs_main.cr
Using compiled compiler at `.build/crystal'
installing
post-installation fixup
gzipping man pages under /nix/store/wjqg8sdcikrymh35rv4dxqadxmlbdcsk-crystal-0.25.0/share/man/
patching script interpreter paths in /nix/store/wjqg8sdcikrymh35rv4dxqadxmlbdcsk-crystal-0.25.0
/nix/store/wjqg8sdcikrymh35rv4dxqadxmlbdcsk-crystal-0.25.0

Mic92 · 2018-06-11T12:22:55Z

@GrahamcOfBorg build mint

GrahamcOfBorg · 2018-06-11T12:23:17Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: mint

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Mic92 · 2018-06-11T12:23:32Z

mint failed to build for me, I have not checked if it failed before.

GrahamcOfBorg · 2018-06-11T12:23:39Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: mint

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-11T12:33:06Z

Failure on x86_64-linux (full log)

Attempted: mint

Partial log (click to expand)

            ^~~~

in lib/baked_file_system/src/loader/loader.cr:31: undefined method 'stat' for File:Class

        io << "  size:            " << File.stat(path).size << ",\n"
                                            ^~~~


builder for '/nix/store/dhsjd0pfvdkrshhp1xcsj9nnipnfx2jj-mint-0.0.3.drv' failed with exit code 1
error: build of '/nix/store/dhsjd0pfvdkrshhp1xcsj9nnipnfx2jj-mint-0.0.3.drv' failed

manveru · 2018-06-11T12:54:09Z

Yeah, looks like there are some incompatible changes in 0.25, one of them is removal of File.stat in favor of File.info... I'll see if we can get Mint fixed today.

sifmelcara

Besides the mint issue, I have some comments

sifmelcara · 2018-06-15T17:09:50Z

pkgs/development/compilers/crystal/default.nix


  src = fetchurl {
    url = "https://github.com/crystal-lang/crystal/archive/${version}.tar.gz";
-    sha256 = "1l7nrrfgz1yxxjphypwzlxj6dbari20p71zb4l0gix09lmas8l6y";
+    sha256 = "1pnx21ky6cqfyv6df4mmjnyd1yh1bvcqkdzq6f0mk0yrkcl57k3q";
  };

  prebuiltName = "crystal-0.24.2-1";


I think we can update prebuilt binaries to 0.25 now? As it have been released 10 hours ago

sounds good.

sifmelcara · 2018-06-15T17:13:27Z

pkgs/development/compilers/crystal/default.nix

@@ -54,9 +54,13 @@ stdenv.mkDerivation rec {
  makeFlags = [ "CRYSTAL_CONFIG_VERSION=${version}"
                "FLAGS=--no-debug"
                "release=1"
-                "all" "docs"


Hmm... why move make docs to postBuild?

Because you couldn't make docs with the old crystal, so the new crystal had to be built first. We probably should disable paralell builds for this too.

Or we can update the prebuilt binary version, right?

exactly, that just wasn't available at the time.

sifmelcara · 2018-06-15T17:19:28Z

Maybe shards need to be updated at the same time?

manveru · 2018-06-16T08:11:53Z

@sifmelcara should all be working now

sifmelcara · 2018-06-16T08:23:01Z

Maybe we should ask mint's maintainer to release a version that is compatible to crystal 0.25?
Using a revision in mint's non-master branch feels not right and it might broken in the future if the branch got deleted.

manveru · 2018-06-16T09:46:27Z

OK, asked him, and he'll release a new version when kemalcr/kemal#452 is merged. So it'll take a bit longer still.

manveru · 2018-06-17T07:20:53Z

Mint 0.0.4 was just released, so I think we're ready for takeoff 💃

sifmelcara · 2018-06-17T09:19:39Z

     wrapProgram $out/bin/crystal \
+        --suffix PATH : ${clang}/bin \
         --suffix CRYSTAL_PATH : lib:$out/lib/crystal \

Why add clang to crystal's PATH?

Besides this, looks good to me (tested on NixOS x86_64)

manveru · 2018-06-17T10:55:08Z

Basically, this allows you to use crystal build without having to add clang to your own PATH, since that's needed for building anything i thought it might be more user-friendly. It doesn't really make the closure larger, since you still need to have llvm anyway.

sifmelcara · 2018-06-17T11:02:13Z

Ok. I think this is ready to get merged but you may need to squash the commits into 3 commits (crystal, shards, mint) :)

manveru · 2018-06-17T11:04:51Z

Done :)

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 11, 2018

sifmelcara reviewed Jun 15, 2018

View reviewed changes

manveru added 3 commits June 17, 2018 13:03

Crystal: 0.24.2 -> 0.25.0

577d54b

Mint: 0.0.3 -> 0.0.4

d9428ce

Shards: 0.7.2 -> 0.8.0

783f515

manveru force-pushed the crystal-2.25.0 branch from c644403 to 783f515 Compare June 17, 2018 11:04

Mic92 merged commit 0eee2f7 into NixOS:master Jun 18, 2018

manveru deleted the crystal-2.25.0 branch June 18, 2018 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crystal: 0.24.2 -> 0.25.0 #41834

Crystal: 0.24.2 -> 0.25.0 #41834

manveru commented Jun 11, 2018 •

edited

Mic92 commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

Mic92 commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

Mic92 commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

manveru commented Jun 11, 2018

sifmelcara left a comment

sifmelcara Jun 15, 2018

manveru Jun 15, 2018

sifmelcara Jun 15, 2018

manveru Jun 15, 2018

sifmelcara Jun 15, 2018

manveru Jun 15, 2018

sifmelcara commented Jun 15, 2018

manveru commented Jun 16, 2018

sifmelcara commented Jun 16, 2018 •

edited

manveru commented Jun 16, 2018

manveru commented Jun 17, 2018

sifmelcara commented Jun 17, 2018

manveru commented Jun 17, 2018

sifmelcara commented Jun 17, 2018

manveru commented Jun 17, 2018

Crystal: 0.24.2 -> 0.25.0 #41834

Crystal: 0.24.2 -> 0.25.0 #41834

Conversation

manveru commented Jun 11, 2018 • edited

Motivation for this change

Things done

Mic92 commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

Mic92 commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

Mic92 commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

manveru commented Jun 11, 2018

sifmelcara left a comment

Choose a reason for hiding this comment

sifmelcara Jun 15, 2018

Choose a reason for hiding this comment

manveru Jun 15, 2018

Choose a reason for hiding this comment

sifmelcara Jun 15, 2018

Choose a reason for hiding this comment

manveru Jun 15, 2018

Choose a reason for hiding this comment

sifmelcara Jun 15, 2018

Choose a reason for hiding this comment

manveru Jun 15, 2018

Choose a reason for hiding this comment

sifmelcara commented Jun 15, 2018

manveru commented Jun 16, 2018

sifmelcara commented Jun 16, 2018 • edited

manveru commented Jun 16, 2018

manveru commented Jun 17, 2018

sifmelcara commented Jun 17, 2018

manveru commented Jun 17, 2018

sifmelcara commented Jun 17, 2018

manveru commented Jun 17, 2018

manveru commented Jun 11, 2018 •

edited

sifmelcara commented Jun 16, 2018 •

edited