Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the problem of kiwisolver not compling in macOS #42074

Merged
merged 1 commit into from
Jun 16, 2018
Merged

Fix the problem of kiwisolver not compling in macOS #42074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkgs/development/python-modules/kiwisolver/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{ lib
, buildPythonPackage
, fetchPypi
, stdenv
, libcxx
}:

buildPythonPackage rec {
Expand All @@ -11,7 +13,9 @@ buildPythonPackage rec {
inherit pname version;
sha256 = "ce3be5d520b4d2c3e5eeb4cd2ef62b9b9ab8ac6b6fedbaa0e39cdb6f50644278";
};


NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.isDarwin "-I${libcxx}/include/c++/v1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to look into why this doesn't work by default, thought we fixed that. We shouldn't have to fix this in every python package that uses c++.


# Does not include tests
doCheck = false;

Expand All @@ -21,4 +25,4 @@ buildPythonPackage rec {
license = lib.licenses.bsd3;
};

}
}