Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.cc-wrapper: Fix sanitizer condition #42175

Merged

Conversation

Ericson2314
Copy link
Member

Motivation for this change

fc9644d accidentally enabled the sanitizer tests for GCC on Darwin, when fixing that case was never attempted. Also inverted the condition from broken to working for clarity.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

fc9644d accidentally enabled the
sanitizer tests for GCC on Darwin, when fixing that case was never
attempted. Also inverted the condition from broken to working for
clarity.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.cc-wrapper

Partial log (click to expand)

these paths will be fetched (0.00 MiB download, 0.00 MiB unpacked):
  /nix/store/s0cd9w8qcs6w7rcvaqambv6ypw0y4i7k-cc-wrapper-test
copying path '/nix/store/s0cd9w8qcs6w7rcvaqambv6ypw0y4i7k-cc-wrapper-test' from 'https://cache.nixos.org'...
/nix/store/s0cd9w8qcs6w7rcvaqambv6ypw0y4i7k-cc-wrapper-test

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.cc-wrapper

Partial log (click to expand)

these paths will be fetched (0.00 MiB download, 0.00 MiB unpacked):
  /nix/store/gl7660bb4d5fp4fkbqs3hg7r7lbwf079-cc-wrapper-test
copying path '/nix/store/gl7660bb4d5fp4fkbqs3hg7r7lbwf079-cc-wrapper-test' from 'https://cache.nixos.org'...
/nix/store/gl7660bb4d5fp4fkbqs3hg7r7lbwf079-cc-wrapper-test

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tests.cc-wrapper

Partial log (click to expand)

these paths will be fetched (0.00 MiB download, 0.00 MiB unpacked):
  /nix/store/b7x53swmf62ymksjw6kd7m4v61xgcnff-cc-wrapper-test
copying path '/nix/store/b7x53swmf62ymksjw6kd7m4v61xgcnff-cc-wrapper-test' from 'https://cache.nixos.org'...
/nix/store/b7x53swmf62ymksjw6kd7m4v61xgcnff-cc-wrapper-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants