Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lief: init at 0.9.0 #42565

Merged
merged 1 commit into from Jun 26, 2018
Merged

lief: init at 0.9.0 #42565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkgs/development/libraries/lief/default.nix
View file
Open in desktop
@@ -0,0 +1,14 @@
{ stdenv, fetchzip }:

fetchzip {
url = https://github.com/lief-project/LIEF/releases/download/0.9.0/LIEF-0.9.0-Linux.tar.gz;
sha256 = "1c47hwd00bp4mqd4p5b6xjfl89c3wwk9ccyc3a2gk658250g2la6";

meta = with stdenv.lib; {
description = "Library to Instrument Executable Formats";
homepage = https://lief.quarkslab.com/;
license = [ licenses.asl20 ];
platforms = platforms.linux;
maintainers = [ maintainers.lassulus ];
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta belongs outside the fetchzip, not in it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use is definitely okay. fetchzip output can be installed as a normal derivation so it is pretty much needed to use meta here. I also much prefer it to the all too common cp -r $src/* $out because it will be fixed output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't know about that. Never seen this use before.

}
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Expand Up @@ -1353,6 +1353,8 @@ with pkgs;

languagetool = callPackage ../tools/text/languagetool { };

lief = callPackage ../development/libraries/lief {};

loadwatch = callPackage ../tools/system/loadwatch { };

loccount = callPackage ../development/tools/misc/loccount { };
Expand Down