Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passff-host: init at 1.0.2 #43048

Merged
merged 1 commit into from
Jul 25, 2018
Merged

passff-host: init at 1.0.2 #43048

merged 1 commit into from
Jul 25, 2018

Conversation

Nadrieril
Copy link
Member

Motivation for this change

This package is the host app for the Firefox extension PassFF. It is similar to browserpass but has a different set of features.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.


installPhase = ''
install -D bin/testing/passff.py $out/passff.py
cp bin/testing/passff.json $out/passff.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't go to $out/ directly, but maybe $out/share/passff-host/passff.json?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that

@matthewbauer
Copy link
Member

@GrahamcOfBorg build passff-host

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: passff-host

Partial log (click to expand)

sed -e "s/_VERSIONHOLDER_/testing/g" < ./install_host_app.bat > ../bin/testing/install_host_app.bat
sed -e "s/_VERSIONHOLDER_/testing/g" < ./install_host_app.sh > ../bin/testing/install_host_app.sh
sed -e "s/_VERSIONHOLDER_/testing/g" < ./passff.py > ../bin/testing/passff.py
sed -e "s/_VERSIONHOLDER_/testing/g" < ./passff.json > ../bin/testing/passff.json
installing
post-installation fixup
strip is /nix/store/sixx1lfy97125f6hxymbwn64cb8z62p3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/yjpg2lsrvwinwsc3yycd839kjl6xxzwj-passff-host-1.0.2
/nix/store/yjpg2lsrvwinwsc3yycd839kjl6xxzwj-passff-host-1.0.2/share/passff-host/passff.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/ni1vd2199rf09rm2f6mlw3k3yc8azm94-python3-3.6.6/bin/python3"
/nix/store/yjpg2lsrvwinwsc3yycd839kjl6xxzwj-passff-host-1.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: passff-host

Partial log (click to expand)

sed -e "s/_VERSIONHOLDER_/testing/g" < ./passff.py > ../bin/testing/passff.py
sed -e "s/_VERSIONHOLDER_/testing/g" < ./passff.json > ../bin/testing/passff.json
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8j75zcskxlrr2a9ivmdswyzai6fl3jaj-passff-host-1.0.2
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8j75zcskxlrr2a9ivmdswyzai6fl3jaj-passff-host-1.0.2
/nix/store/8j75zcskxlrr2a9ivmdswyzai6fl3jaj-passff-host-1.0.2/share/passff-host/passff.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/3f6sjic6a42pnj83q0v343nl2b74gn0n-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/8j75zcskxlrr2a9ivmdswyzai6fl3jaj-passff-host-1.0.2...
/nix/store/8j75zcskxlrr2a9ivmdswyzai6fl3jaj-passff-host-1.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: passff-host

Partial log (click to expand)

sed -e "s/_VERSIONHOLDER_/testing/g" < ./passff.py > ../bin/testing/passff.py
sed -e "s/_VERSIONHOLDER_/testing/g" < ./passff.json > ../bin/testing/passff.json
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nrl4cq0393ia53x2viqml5q6x5yb0m9y-passff-host-1.0.2
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/nrl4cq0393ia53x2viqml5q6x5yb0m9y-passff-host-1.0.2
/nix/store/nrl4cq0393ia53x2viqml5q6x5yb0m9y-passff-host-1.0.2/share/passff-host/passff.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/fwjyk4kylp4adridcp11bw44i2cx5v10-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/nrl4cq0393ia53x2viqml5q6x5yb0m9y-passff-host-1.0.2...
/nix/store/nrl4cq0393ia53x2viqml5q6x5yb0m9y-passff-host-1.0.2

@matthewbauer matthewbauer merged commit 444857b into NixOS:master Jul 25, 2018
@Nadrieril
Copy link
Member Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants