Commits on Sep 28, 2014

1. Exponentially reduce computation time needed for replace-dependency b… …

   …y using memoization.
   
   This patch makes two changes.
   
   (1) It memoizes the computation of dependsOnOld.
   (2) It replaces rewrittenDerivations with a similar memoized table rewriteMemo.
   
   This prevents the entire tree of run-time dependencies from being traversed and instead only traverses the graph of run-time dependencies.
   In the case of deep dependency changes (such as changing one's bash version for an entire NixOS system) this can lead to an exponential speedup in processing time
   because shared dependencies are no longer traversed multiple times.
   
   This patch isn't quite derivation-per-derivation equivalent to the original computation.
   There are two immaterial differences.
   
   (1) The previous version would always call upon sed to replace oldDependency with newDependency even when the store object being updated doesn't directly depend on
   oldDependency.
   The new version only replaceds oldDependency with newDependency when the store object being updated actually directly depends on oldDependency (which means there is
   actually a hash to replace).
   (2) The previous version would list the old store object as a source input of the new store object, *except* for the root derivation being updated.  Because the
   root derivation being updated has its actual derivation avaiable the previous verions would make the updated root derivation depend on the old derivation as a
   derivation input instead of a source input.
   The new version always lists the old store object as a source input, including the root derivation.

   

   roconnor committed Sep 28, 2014
   Configuration menu

   • View commit details
   • Copy full SHA for 94c6af4
   • Browse repository at this point

   Copy the full SHA

   94c6af4 View commit details

   Browse the repository at this point in the history