Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.24.1 -> 1.25.0 #43132

Merged
merged 1 commit into from Jul 7, 2018
Merged

vscode: 1.24.1 -> 1.25.0 #43132

merged 1 commit into from Jul 7, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 7, 2018

Also includes missing lib, libgtk-x11-2.0.so.0

Motivation for this change

Resolves executable error: error while loading shared libraries: libgtk-x11-2.0.so.0: cannot open shared object file: No such file or directory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Resolve missing lib, libgtk-x11-2.0.so.0
@worldofpeace
Copy link
Contributor

Does the thing. 👍

@infinisil infinisil merged commit 2207524 into NixOS:master Jul 7, 2018
@infinisil
Copy link
Member

Thanks!

@eadwu eadwu deleted the vscode/1.25.0 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants