Python on Darwin: Don't depend on glibcLocales #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
added a commit
that referenced
this pull request
Sep 29, 2014
Python on Darwin: Don't depend on glibcLocales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibcLocales isn't supported on Darwin any more, and as such it should not be used as a dependency.
Not sure if this is the best way to fix it; perhaps the package should be made optional in top-level instead (
nixpkgs/pkgs/top-level/all-packages.nix
Line 5004 in 93fd8fb
anyway this removes some duplication, so it's good to apply in any case 馃榿