-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in nixos/tests/taskserver.nix #43284
Conversation
Hmm, I wonder if "Templace" should have been "Template", too. |
Good catch, @GrahamcOfBorg ! edit: I mean @vcunat 😆 |
@GrahamcOfBorg test taskserver |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.taskserver Partial log (click to expand)
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: tests.taskserver Partial log (click to expand)
|
Well, one has to fix both occurrences of the identifier – that's why I wondered about the typo, but perhaps with some clever auto-complete it's possible to make the same typo twice... |
The eval error seems unrelated to this PR. Actually, I cannot find evidence of this test ever being run as far as hydra logs go. Will investigate. |
Needs to get fixed here as well: nixpkgs/nixos/tests/taskserver.nix Lines 51 to 53 in 0b0696f
|
Now just squash the commits into one |
FYI: Fixed eval error of this test in 7ac794f. The fix is independent of this PR. |
355da15
to
e110e8c
Compare
Rebased and squashed. |
Thank you! |
@OliverEvans96 in the future, please format your commit messages as described in CONTRIBUTING.MD . It's a convention to make our git logs easier to read and search. Thank you. |
Will do, thank you! |
snakoil
->snakeoil