Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aerospike: init at 4.2.0.4 #43428

Merged
merged 1 commit into from Jul 16, 2018
Merged

aerospike: init at 4.2.0.4 #43428

merged 1 commit into from Jul 16, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jul 12, 2018

Motivation for this change

A NoSQL database.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This was originally filed by @volth in #26855.

@kalbasit kalbasit changed the title [DRAFT] aerospike: init at 4.2.0.4 aerospike: init at 4.2.0.4 Jul 12, 2018
@kalbasit
Copy link
Member Author

@volth do you know why the build is failing? I only see is not supported on ‘aarch64-unknown-linux-gnu’, refusing to evaluate., which makes sense because the platform only includes x86_64-linux.

@kalbasit
Copy link
Member Author

@volth can we get this merged?

@kalbasit
Copy link
Member Author

alright, maybe @adisbladis can help to merge this?

@fpletz
Copy link
Member

fpletz commented Jul 15, 2018

Thanks! Code looks fine. 👍

Please fix up the commit messages and/or squash some of them.

@kalbasit
Copy link
Member Author

@fpletz done, PTAL.

BTW, why don't you always Squash merge PRs? It makes the master branch a lot cleaner.

@fpletz
Copy link
Member

fpletz commented Jul 16, 2018

Well, I didn't squash this because I was hoping you would combine all those fixup commits into sensible, topical commits that would retain the authorship from both of you.

Maybe add at least a co-authored-by?

Co-authored-by: Volth <volth@webmaster.ms>
@kalbasit
Copy link
Member Author

kalbasit commented Jul 16, 2018

@fpletz I completely agree; My apologies @volth, I'm pretty exhausted this weekend and it seems to be affecting my manners. I added the Co-authored-by to the single commit I have here; I hope that is enough.

@fpletz
Copy link
Member

fpletz commented Jul 16, 2018

Yeah, for every line it is too much but in general we like the work of other's to be properly attributed to them. Not only for being able to ask the author about their code but out of politeness. Also please not that I could've for instance added the co-authored-by myself and I regularly do so on trivial issues, but in his case I wanted both of your feedback first.

Thanks! 👍

@fpletz fpletz closed this Jul 16, 2018
@fpletz fpletz reopened this Jul 16, 2018
@fpletz fpletz merged commit fd2448b into NixOS:master Jul 16, 2018
@kalbasit kalbasit deleted the add-aerospike branch July 16, 2018 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants