Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofi-systemd: init at 0.1.0 #43550

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Conversation

colonelpanic8
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

patchShebangs $out/bin

wrapProgram $out/bin/rofi-systemd --prefix PATH : "${wrapperPath}"
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using

{
  postFixup = ''
    wrapProgram $out/bin/rofi-systemd --prefix PATH : "${wrapperPath}"
  '';
}

instead of overriding the fixupPhase would be more elegant here.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build rofi-systemd

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rofi-systemd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rofi-systemd

Partial log (click to expand)

unpacking source archive /nix/store/kvnazkywglcd45xcy617arvzzm17yn1c-source
source root is source
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/x45sb2c37ibg17mlgylfy5iv4l200hjh-rofi-systemd-0.1.0/bin
/nix/store/x45sb2c37ibg17mlgylfy5iv4l200hjh-rofi-systemd-0.1.0/bin/rofi-systemd: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/sh"
/nix/store/x45sb2c37ibg17mlgylfy5iv4l200hjh-rofi-systemd-0.1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rofi-systemd

Partial log (click to expand)

source root is source
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/ww2q305x49p2gjgla52hjyfmn123mwzl-rofi-systemd-0.1.0/bin
/nix/store/ww2q305x49p2gjgla52hjyfmn123mwzl-rofi-systemd-0.1.0/bin/rofi-systemd: interpreter directive changed from "/usr/bin/env sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
/nix/store/ww2q305x49p2gjgla52hjyfmn123mwzl-rofi-systemd-0.1.0

@matthewbauer matthewbauer merged commit 3d64482 into NixOS:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants