-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eclib: 20171219 -> 20180710 #43563
eclib: 20171219 -> 20180710 #43563
Conversation
Success on x86_64-linux (full log) Attempted: eclib Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: eclib Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: eclib Partial log (click to expand)
|
Seems OK, waiting for the test results. |
Also includes the necessary sage compatibility patch, borrowed from ArchLinux.
There was one more cosmetical issue, now its ready to go :) I also added a comment mentioning which sage tests are likely to fail. I think this would be another nice use-case for #36842: Since dependencies usually break at the interface, it should be possible to make a quick individualized "did this break sage" check for every dependency that is likely to do so. |
Success on aarch64-linux (full log) Attempted: eclib Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: eclib Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: eclib Partial log (click to expand)
|
Motivation for this change
Since this should build just fine on darwin, I've experimentally removed the platforms restriction. Lets see what ofborg says.
I'm still running the sage tests locally, so don't merge just yet.
closes #43476
@7c6f434c
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)