Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseeffects, lightdm-gtk-greeter, gxmessage, viking: depend on hicolor-icon-theme #43633

Merged
merged 4 commits into from Aug 16, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Avoid conflicts on share/icons/hicolor/icon-theme.cache.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This avoids conflicts on `share/icons/hicolor/icon-theme.cache`.
This avoids conflicts on `share/icons/hicolor/icon-theme.cache`.
This avoids conflicts on `share/icons/hicolor/icon-theme.cache`.
This avoids conflicts on `share/icons/hicolor/icon-theme.cache`.
@jfrankenau
Copy link
Member Author

pinging @jtojnar as the maintainer of pulseeffects

@matthewbauer
Copy link
Member

@GrahamcOfBorg build pulseeffects lightdm-gtk-greeter gxmessage viking

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pulseeffects, gxmessage, viking

The following builds were skipped because they don't evaluate on x86_64-linux: lightdm-gtk-greeter

Partial log (click to expand)

make[1]: Leaving directory '/build/viking-1.6.2'
glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5gnbnp15acpx81nldkhpb9avjmv4fwpn-viking-1.6.2
shrinking /nix/store/5gnbnp15acpx81nldkhpb9avjmv4fwpn-viking-1.6.2/bin/.viking-wrapped
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5gnbnp15acpx81nldkhpb9avjmv4fwpn-viking-1.6.2/bin
patching script interpreter paths in /nix/store/5gnbnp15acpx81nldkhpb9avjmv4fwpn-viking-1.6.2
checking for references to /build in /nix/store/5gnbnp15acpx81nldkhpb9avjmv4fwpn-viking-1.6.2...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pulseeffects, gxmessage, viking

The following builds were skipped because they don't evaluate on aarch64-linux: lightdm-gtk-greeter

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c421vs3l9z42n1jaj2y2gwhi3i7zijyg-viking-1.6.2
shrinking /nix/store/c421vs3l9z42n1jaj2y2gwhi3i7zijyg-viking-1.6.2/bin/.viking-wrapped
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c421vs3l9z42n1jaj2y2gwhi3i7zijyg-viking-1.6.2/bin
patching script interpreter paths in /nix/store/c421vs3l9z42n1jaj2y2gwhi3i7zijyg-viking-1.6.2
checking for references to /build in /nix/store/c421vs3l9z42n1jaj2y2gwhi3i7zijyg-viking-1.6.2...
error: build of '/nix/store/y08h7h0rapm4giq6jqix0v9r50x519cy-pulseeffects-4.2.6.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pulseeffects, lightdm-gtk-greeter, gxmessage, viking

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@jtojnar jtojnar merged commit a82ea67 into NixOS:master Aug 16, 2018
@jfrankenau jfrankenau deleted the fix-icon-cache branch August 16, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants