Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package scuttlebot #43661

Closed
wants to merge 4 commits into from
Closed

Package scuttlebot #43661

wants to merge 4 commits into from

Conversation

patrl
Copy link
Contributor

@patrl patrl commented Jul 17, 2018

Motivation for this change

Scuttlebot provides a command-line utility, and therefore warrants packaging under the nodePackages attribute.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@patrl
Copy link
Contributor Author

patrl commented Jul 27, 2018

Can someone at least assign this a label?

@taku0
Copy link
Contributor

taku0 commented Jul 28, 2018

Maybe, this should be spitted into two PRs.

@patrl
Copy link
Contributor Author

patrl commented Jul 28, 2018

@taku0 I followed the current instructions for packaging node packages here. The pertinent line:

Run the script: cd pkgs/development/node-packages && ./generate.sh.

generate.sh triggers a rerun of node2nix on the package sets, which leads to this merge conflict.

@xeji
Copy link
Contributor

xeji commented Oct 24, 2018

I know very little about node packaging, but the merge conflict might have been caused by another change to node packages being merged while you were working on this. Have you tried running generate.sh again after rebasing your changes on current master?

@infinisil
Copy link
Member

@xeji Indeed, it's a common problem with node packages, every PR that updates/adds a node package conflicts with every other PR doing that..

@infinisil
Copy link
Member

@GrahamcOfBorg build nodePackages.scuttlebot

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: nodePackages.scuttlebot

Partial log (click to expand)

                                 Dload  Upload   Total   Spent    Left  Speed

trying https://registry.npmjs.org/wrap-fn/-/wrap-fn-0.1.5.tgz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4094  100  4094    0     0   173k      0 --:--:-- --:--:-- --:--:--  173k
100  2271  100  2271    0     0  84111      0 --:--:-- --:--:-- --:--:-- 87346
100  2477  100  2477    0     0   134k      0 --:--:-- --:--:-- --:--:--  134k
cannot build derivation '/nix/store/81zf5gh75npp8kpy7fniv3hgcjj1m044-node-scuttlebot-13.0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/81zf5gh75npp8kpy7fniv3hgcjj1m044-node-scuttlebot-13.0.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nodePackages.scuttlebot

Partial log (click to expand)

npm ERR! leveldown@3.0.2 install: `prebuild-install || node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the leveldown@3.0.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /private/tmp/nix-build-node-scuttlebot-13.0.1.drv-0/.npm/_logs/2018-10-29T12_36_29_666Z-debug.log
builder for '/nix/store/d3w9ykclvl7y4rpwvvfxmsjyqqvr7a97-node-scuttlebot-13.0.1.drv' failed with exit code 1
error: build of '/nix/store/d3w9ykclvl7y4rpwvvfxmsjyqqvr7a97-node-scuttlebot-13.0.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: nodePackages.scuttlebot

Partial log (click to expand)

npm ERR! sodium-native@2.2.2 install: `node-gyp-build "node preinstall.js" "node postinstall.js"`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the sodium-native@2.2.2 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/.npm/_logs/2018-10-29T10_16_53_699Z-debug.log
builder for '/nix/store/2dblbvxnrl2zr14x0nabmk0qxdpq0xp9-node-scuttlebot-13.0.1.drv' failed with exit code 1
error: build of '/nix/store/2dblbvxnrl2zr14x0nabmk0qxdpq0xp9-node-scuttlebot-13.0.1.drv' failed

@patrl
Copy link
Contributor Author

patrl commented Oct 29, 2018

Hmm. Something went wrong here, and I'm worried the rebase was messy. I'm going to close this PR and make a clean one referencing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants