New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpv: 0.28.2 -> 0.29.0 #43977
mpv: 0.28.2 -> 0.29.0 #43977
Conversation
@GrahamcOfBorg eval |
Success on x86_64-linux (full log) Attempted: mpv Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: mpv Partial log (click to expand)
|
mpc-qt seems to be broken, however this was already the case before this updated: https://hydra.nixos.org/build/75980372 |
@grahamc Why didn't this build on Darwin? This PR breaks mpv on Darwin 😞 |
@GrahamcOfBorg build mpv |
Success on x86_64-linux (full log) Attempted: mpv Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: mpv Partial log (click to expand)
|
Due to the missing sandbox on macOS only trusted user can start macOS builds. |
Failure on x86_64-darwin (full log) Attempted: mpv Partial log (click to expand)
|
My wild guess is that the shebangs needs to be patched on macOS: https://github.com/mpv-player/mpv/blob/master/version.sh#L1 |
I tried to fix this here, but stuck without having macOS: #44147 |
https://github.com/mpv-player/mpv/releases/tag/v0.29.0
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)