-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android-file-transfer: init at 3.4 #44017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also squash your commits into one commit.
''; | ||
meta = with stdenv.lib; { | ||
description = "Reliable MTP client with minimalistic UI"; | ||
longDescription = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please either add a longDescription
or remove this.
description = "Reliable MTP client with minimalistic UI"; | ||
longDescription = '' | ||
''; | ||
homepage = "http://whoozle.github.io/android-file-transfer-linux/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quotes are not necessary around URLs.
Ok, I fixed those issues. Any other suggestions? |
It looks like it is pretty rare for a package repository to have something called "android-file-transfer-qt". Generally we try to respect the defaults of the upstream software, so in this case, it looks like the default is to provide the graphical program, so I'd recommend having it turned on. But, it would also be okay to plan to add that later if it is much harder to package it. Keep in mind people can reuse or override this expression later, so providing optional arguments to the package isn't necessary. |
@GrahamcOfBorg build android-file-transfer |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: android-file-transfer Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: android-file-transfer Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: android-file-transfer Partial log (click to expand)
|
Getting it to build with Qt was straightforward. I still think its a good idea to have a knob there for people to easily turn the Qt part off. Qt is a huge dependency. I implemented a version in a seperate branch, which makes Qt optional: Still if you think it's too much trouble, I can just add the Qt bits to this pull request. By the way, with or without Qt, this might build on darwin (at least according to upstream). |
I prefer to have only one version with Qt turned on. I think you shouldn't put the option into nixpkgs unless it is going to be used somewhere in nixpkgs. Someone who wants to reduce the size and use Qt, can fairly easily do it themselves.
If you think it might build on Darwin, change the platforms to "unix" and we'll see if OfBorg builds it! |
0f3e3e3
to
87b9436
Compare
Ok, I pushed the necessary changes for building with Qt. Also set platforms to unix. |
@GrahamcOfBorg build android-file-transfer |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: android-file-transfer Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: android-file-transfer Partial log (click to expand)
|
Darwin failed because |
Based on the comments here #36346 |
Success on aarch64-linux (full log) Attempted: android-file-transfer Partial log (click to expand)
|
Ok, linux only then for now. |
@GrahamcOfBorg build android-file-transfer |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: android-file-transfer Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: android-file-transfer Partial log (click to expand)
|
I changed platforms back to linux. Feel free to merge, when you are satisfied with the code. |
Success on x86_64-linux (full log) Attempted: android-file-transfer Partial log (click to expand)
|
thanks! |
Motivation for this change
This adds the android-file-transfer (Android File Transfer For Linux) package.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)