Udisks2 xfce

[ierton]

This patchset fixes removable media mounting in gvfs applications, in particular, in Xfce's file manager Thunar.

[viric]

What is udisks2 for? Does udisks1 work for other applications, and gvfs requires udisks2?

[vcunat]

Without udisks2 thunar can't (un)mount removable media.

[vcunat]

I don't have a clue which packages (can) use udisks(2). git grep shows nothing, but maybe through dbus some can find it -- it's a bit impure but I don't see how to better handle such cases.

[bluescreen303]

isn't udisks2 just a drop-in replacement for udisks1?

[ierton]

The only package which depends on udisks2 is gvfs. One may say that this
patchset just improves gvfs by adding one more backend into the set. Gvfs
is available to users by means of $GIO_EXTRA_MODULES which is set in
profile.sh, as before.

2013/4/3 Vladimír Čunát notifications@github.com

I don't have a clue which packages (can) use udisks(2). git grep shows
nothing, but maybe through dbus some can find it -- it's a bit impure but I
don't see how to better handle such cases.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/441#issuecomment-15842144
.

[vcunat]

@bluescreen303: I believe it is, although some packages may need updating.

[ierton]

isn't udisks2 just a drop-in replacement for udisks1?

I didn't check but author claimed that they preserve DBus interface compatibility. CLI interface is changed. There are many negative posts on the web about this trend. Functionality is the same, luckily.

[ierton]

Note: I've updated the request. The change is in the commit this request is based on. Currently it is the commit of my last system update 0caed13. No changes in request itself were made.

[vcunat]

Tadaaa! I found the problem! And solved it already, only it still introduces some crashes.

The problem was that xfce4session was still designed around ConsoleKit which is deprecated by systemd now. I found that they recently fixed this in git to work with systemd but haven't released yet, so I added a patch for the single change.

https://bugzilla.xfce.org/show_bug.cgi?id=8729
vcunat@d54a060

[vcunat]

Ah, I see that the crashes are probably independent of this issue (I'm testing too many things at once :-).

https://bugzilla.xfce.org/show_bug.cgi?id=9709 Here it's connected to glib>2.35, but the real root seems to be much deeper (glibc) https://bugs.archlinux.org/task/34630#comment108896 .

[vcunat]

In any case, this change should be stable if applied on master, then. We only need to really test it is so, as whole-x-session crashes can be very frustrating (volunteers welcome).

[ierton]

Cool but strange: information about mounted volumes comes from gvfs, but it is systemd who monitors mountable ones. Are they doing same things?

[vcunat]

I believe it was about authorization: to manipulate with USB volumes you have to be in a session that is physically at the computer. ConsoleKit used to track that, now it's systemd through polkit (probably, I don't know much about this).

[vcunat]

I'm running without a crash for a few days now (atop x-updates). Moreover, crashes seem to have been only caused by the independent glib update and disappeared after fe8c1c4.

[ierton]

I've just installed vcunat@d54a060, works fine. Now I can successfully reboot/poweroff from within Xfce! Should I expect any progress in re-mounting media with the fix?

[vcunat]

Yes, for me the media are shown and mount on-click. It's also in x-updates now.

[ierton]

Well, for me it only solves reboot/poweroff. But I just cherry picked that single commit, so probably there are something else vital in x-updates. And yes, no crashes. So happiness +1 :)

[vcunat]

Aha, well, what login manager do you use?

I only tried it with lightdm, even with this patch vcunat@d4a0ddf which is neither in x-updates yet (nor in lightdm release). It should do something with systemd support... I thought the patch didn't work as I was still getting the log message that got me to this patch, but maybe it did fix this problem.

[ierton]

I use slim as login manager. May be it is the point. Slim has its own
ability to reboot/poweroff the machine. I'll try them soon and report.

2013/4/30 Vladimír Čunát notifications@github.com

Aha, well, what login manager do you use?

I only tried it with lightdm, even with this patch vcunat@d4a0ddfhttps://github.com/vcunat/nixpkgs/commit/d4a0ddfd0968a36c8a5138d381d1dc9ae215ca08which is neither in x-updates yet (nor in lightdm release). It should do
something with systemd support... I thought the patch didn't work as I was
still getting the log message that got me to this patch, but maybe it did
fix this problem.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/441#issuecomment-17237588
.

[vcunat]

Yes, that might be the cause, missing polkit support in slim. We should also test this against KDM and the committed lightdm.

[vcunat]

I tested USB disk mounting on my machine with thunar + xfce4session + (lightdm or KDM). All works on recent x-updates branch :-)

[ierton]

Indeed, slim lacks polkit support. But lightdm looks nice, I'll think about
moving to it.

2013/5/4 Vladimír Čunát notifications@github.com

I tested USB disk mounting on my machine with thunar + xfce4session +
(lightdm or KDM). All works on recent x-updates branch :-)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/441#issuecomment-17431820
.

[bluescreen303]

kde 4.10 does use/need udisks2
https://bugs.kde.org/show_bug.cgi?id=310335

So I wonder what would be the best way for the nixos kde4 module to choose udisks/udisks2 based on the chosen kde version (by manual override in nixpkgs).

[Phreedom]

Does this mean that you currently can't activate both KDE and XFCE module? Also, I don't see any assertion which prevents activating udisks and udisks2 at once. As to picking the version, adding wantsUdisks2 passthru to kdelibs shouldn't be a problem at all.

[vcunat]

I don't see a (theoretical) problem in activating both udisk services -- each program just calls the one that it wants. I had both kde and xfce activated, and certainly the thunar mounting worked (I'm not sure I tried the other).

[Phreedom]

Now, you can adjust the kde module to pick the most appropriate udisks2: a6b9035

[vcunat]

@Phreedom: I would expect the whole kde SC to switch udisks version at once (that's probably the way it's done in most distros), but the option can't hurt.

[Phreedom]

@vcunat: grep udisk -ir pkgs/desktops/kde* is empty, and that probably means that kde picks up whatever is available on the system. kdelibs is the package which contains the udisks code(99% chance or so). So when nixos kde module makes core kde apackages available, it can check for this passthru and pick the most appriate udisks verion.

[vcunat]

@Phreedom: I probably didn't really get your intentions... so you mean to check this attribute in NixOS module to include udisks2 when one chooses kde >= 4.10?

[Phreedom]

@vcunat: yes

[vcunat]

@Phreedom: then this seems perfect to me, sorry.