New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm 3.8, 3.9, 4: WIP split out compiler-rt for other versions #44206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold off on merging any of this until 18.09 is branched off.
@matthewbauer well on the other hand we already did this with the far more important LLVMs, without downstream issues IIRC, so if I can debug the two build failures here (I got locally) it should be a master-only PR that gets everything into a consistent state for the release. |
6 was already done, 5 is is Darwin's stdenv so holding off to avoid mass rebuild, < 3.8 is too old for separate compiler-rt.
57d92be
to
627fe8e
Compare
Wouldn't llvm-5 be inconsistent with all the other version then? |
Ok fair enough. |
There's two failures on Linux, and I cannot currently test Darwin. Help with this would be appreciated. |
This is dead? |
I just never finished debugging it! Maybe I can soon now that I have access to beefier machines :). |
The LLVM versions in question are all gone now, and it looks like this is done for all of the versions currently in Nixpkgs. This can probably be closed. |
Motivation for this change
This is good for build parallelism and cross compilation.
6 was already done, 5 is is Darwin's stdenv so holding off to avoid mass
rebuild, <3.9 is too old for separate compiler-rt.
Things done
There are some build failures to track down, however. I'm opening this so others can possibly assist.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)