Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm 3.8, 3.9, 4: WIP split out compiler-rt for other versions #44206

Closed
wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

Motivation for this change

This is good for build parallelism and cross compilation.

6 was already done, 5 is is Darwin's stdenv so holding off to avoid mass
rebuild, <3.9 is too old for separate compiler-rt.

Things done

There are some build failures to track down, however. I'm opening this so others can possibly assist.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 added 2.status: work-in-progress 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform labels Jul 29, 2018
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on merging any of this until 18.09 is branched off.

@Ericson2314
Copy link
Member Author

@matthewbauer well on the other hand we already did this with the far more important LLVMs, without downstream issues IIRC, so if I can debug the two build failures here (I got locally) it should be a master-only PR that gets everything into a consistent state for the release.

6 was already done, 5 is is Darwin's stdenv so holding off to avoid mass
rebuild, < 3.8 is too old for separate compiler-rt.
@LnL7
Copy link
Member

LnL7 commented Aug 2, 2018

Wouldn't llvm-5 be inconsistent with all the other version then?

@matthewbauer
Copy link
Member

Ok fair enough.

@Ericson2314
Copy link
Member Author

There's two failures on Linux, and I cannot currently test Darwin. Help with this would be appreciated.

@vcunat
Copy link
Member

vcunat commented Feb 26, 2019

This is dead?

@Ericson2314
Copy link
Member Author

Ericson2314 commented Feb 26, 2019

I just never finished debugging it! Maybe I can soon now that I have access to beefier machines :).

@Gaelan
Copy link
Contributor

Gaelan commented May 8, 2020

The LLVM versions in question are all gone now, and it looks like this is done for all of the versions currently in Nixpkgs. This can probably be closed.

@Ericson2314 Ericson2314 closed this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: work-in-progress 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants