plasma-nm: fix path to mobile broadband provider file #44302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new mobile broadband connection with the plasma network manager connection editor, it tries to find a file containing provider information somewhere in /usr/share/... . The build recipe contains a patch to fix the lookup path such that it finds the file in the corresponding package, probably added due to NixOS#9389 . The actual lookup path is injected into the patch file with substituteAll. With commit a31d98f , the variable name used in subsituteAll changed from mobile_broadband_provider_info to mobile-broadband-provider-info (underscores in package names turned into dashes). Apparently, substituteAll can't handle dashes in variable names. Consequently, the variable name was no longer resolved. plasma-nm failed to create new mobile broadband connections; the connection creator silently exited and logged the error > plasma-nm: Error opening providers file "@mobile-broadband-provider-info@/share/mobile-broadband-provider-info/serviceproviders.xml" This commit keeps the dashes in package names, but it restores the underscores in the variable used by substituteAll, thereby ensuring the variable gets resolved properly.
|
Bah, this has bitten me in the rear multiple times. Maybe |
|
@GrahamcOfBorg build plasma-nm |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: plasma-nm Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: plasma-nm Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: plasma-nm Partial log (click to expand)
|
|
I'd like to kindly ask you how to get rid of it? |
xeji
pushed a commit
that referenced
this pull request
Aug 24, 2018
When creating a new mobile broadband connection with the plasma network manager connection editor, it tries to find a file containing provider information somewhere in /usr/share/... . The build recipe contains a patch to fix the lookup path such that it finds the file in the corresponding package, probably added due to #9389 . The actual lookup path is injected into the patch file with substituteAll. With commit a31d98f , the variable name used in subsituteAll changed from mobile_broadband_provider_info to mobile-broadband-provider-info (underscores in package names turned into dashes). Apparently, substituteAll can't handle dashes in variable names. Consequently, the variable name was no longer resolved. plasma-nm failed to create new mobile broadband connections; the connection creator silently exited and logged the error > plasma-nm: Error opening providers file "@mobile-broadband-provider-info@/share/mobile-broadband-provider-info/serviceproviders.xml" This commit keeps the dashes in package names, but it restores the underscores in the variable used by substituteAll, thereby ensuring the variable gets resolved properly. (cherry picked from commit bdf6f85)
|
Thank you @xeji. Unfortunately I still get the same error on |
|
That's because the channel has not advanced to include the fix yet. Please wait a little. |
|
@xeji, 59c3c4d couldn't be advanced for the channel nixos-18.03 yet. But it successfully advanced in the channel nixos-18.03-small. |
|
Don't worry, the commit will be available in the |
|
One more thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new mobile broadband connection
with the plasma network manager connection editor,
it tries to find a file containing provider
information somewhere in /usr/share/... .
The build recipe contains a patch to fix the lookup path
such that it finds the file in the corresponding package,
probably added due to
#9389 .
The actual lookup path is injected into
the patch file with substituteAll.
With commit a31d98f ,
the variable name used in subsituteAll changed from
mobile_broadband_provider_info to mobile-broadband-provider-info
(underscores in package names turned into dashes).
Apparently, substituteAll can't handle dashes in variable names.
Consequently, the variable name was no longer resolved.
plasma-nm failed to create new mobile broadband connections;
the connection creator silently exited and logged the error
This commit keeps the dashes in package names, but it
restores the underscores in the variable used by substituteAll,
thereby ensuring the variable gets resolved properly.
Motivation for this change
Restore ability to create mobile broadband connections with the plasma network manager frontend.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/): there are nonenix path-info -Sbefore and after)cc @ttuegel (sorry, you are the last one who touched this according to git log ... there is no maintainer given in the build recipe)