New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skypeforlinux: Add GSettings schemas #44652
skypeforlinux: Add GSettings schemas #44652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try using wrapGAppsHook
instead.
@jtojnar I tried adding There are a couple ways I could see this being resolved:
Or maybe there's some other simple way that I'm missing? I'd be happy to implement any option. |
Yeah, I wanted to do 2. for a long time but never got to i You can still run Alternately, you can move the symlink creation to |
@@ -68,6 +68,8 @@ in stdenv.mkDerivation { | |||
|
|||
inherit src; | |||
|
|||
nativeBuildInputs = [ gtk3 wrapGAppsHook ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, gtk3
should not be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the same thing, but the error still appears on my machine if gtk3
is not in nativeBuildInputs
.
Perhap's it's because I'm not using Gnome DE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. wrapGAppsHook
should bring GTK already. Though if you need it here, move it to buildInputs
. Just the hook is native.
buildInputs = [ dpkg makeWrapper ]; | ||
nativeBuildInputs = [ wrapGAppsHook ]; | ||
|
||
buildInputs = [ dpkg gtk3 makeWrapper ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, you do not need gtk3
but glib
’s setup hooks. Could you add it to nativeBuildInputs
with a comment “for setup hook populating GSETTINGS_SCHEMAS_PATH
”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also makeWrapper
is not used.
@jtojnar Let me know if there is any other changes you think are necessary |
Pushed to master as 3b2f3e5 |
cherry-picked and squashed from #44652
Motivation for this change
Attempting to upload an attachment in Skype causes it to crash, with the error:
No GSettings schemas are installed on the system
These changes should resolve that issue.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)