-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/tests/networking: fix routes and virtual tests #45649
Conversation
The output format of `ip route` changed, it now explicitly shows "proto static" for static routes.
`ip route` now displays extended tun attributes, so the expected output of this test changed. Upstream change: https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=118eda77d6602616bc523a17ee45171e879d1818
@GrahamcOfBorg test networking.scripted.routes |
Success on aarch64-linux (full log) Attempted: tests.networking.networkd.routes Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: tests.networking.networkd.virtual Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: tests.networking.scripted.routes Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: tests.networking.scripted.virtual Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: tests.networking.scripted.routes Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: tests.networking.scripted.virtual Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: tests.networking.networkd.routes Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: tests.networking.networkd.virtual Partial log (click to expand)
|
Motivation for this change
The "routes" and "virtual" networking tests have failed on hydra for quite some time because the output of
ip route
has changed. FIxed by modifying the expected outputs coded in the tests.Hydra failures:
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.networking.networkd.routes.x86_64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.networking.networkd.virtual.x86_64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.networking.scripted.routes.x86_64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.networking.scripted.virtual.x86_64-linux
Things done
cc #40257