ruby: default to version 2.5

[manveru]

Motivation for this change

Should be done before 18.09, Ruby 2.6 is almost out as well.

@zimbatm

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[manveru]

Tried running nox, but it fails with Too many heap sections: Increase MAXHINCR or MAX_HEAP_SECTS

[Mic92]

@manveru you can use nix-review, which will use ofborg's evaluation instead.

[samueldr]

From a nix-review:

error: build of
'/nix/store/0lr3xd7cva5hq640s5hnzk2k3hl694ys-usbguard-0.7.4.drv', 
'/nix/store/1rddy8qgn1mami3bhr21hcsvnl4cxi2a-ihaskell-with-packages.drv', 
'/nix/store/34zmh6rv5pzs1sx4k7ymxi5abf8avvx9-gpaste-3.28.2.drv', 
'/nix/store/3hss0aql245h85a3ds7ivfajbpxkm92p-qtwebkit-5.9.1.drv', 
'/nix/store/5fps2s5q8c35wkasa8017xwcccq8d10h-electrum-3.1.3.drv', 
'/nix/store/6rh1dkkjjwwznpy627znq875338n66aj-qtwebkit-5.6.3.drv', 
'/nix/store/7rw4mqhz3yjfzic6dd7xrzclz1hyy0hf-kmymoney-5.0.1.drv', 
'/nix/store/97317ns455567xy17g66fgir80yrqjg6-cheese-3.28.0.drv', 
'/nix/store/ap4n7snjpjbrcbjzllnxs2g3ly42hcm0-empathy-3.25.90.drv', 
'/nix/store/c6lg0v2qgds8cj7zp0gjzpppmh1lgxhl-golden-cheetah-3.4.drv', 
'/nix/store/cwwmp802zq7458zvfgkld5wywi4aq9p3-weechat.drv', 
'/nix/store/dj35agfi1ppx7dqw617wpzh2akn9hbwl-styx-0.7.1.drv', 
'/nix/store/gy6ilm075m370ad5fjf46zylkpkx3xkl-electron-cash-3.1.6.drv', 
'/nix/store/hks9iz51dh2h3jqlly0nf6rw6gkra0in-leksah-8.4.3.drv', 
'/nix/store/jhsf4y52cck3l5zyzm06lxqszpq0rdc6-qt-full-5.6.3.drv', 
'/nix/store/jksj7r9l6d2zz0w14md950n47ndavnp8-gnome-contacts-3.28.2.drv', 
'/nix/store/l2f9cc3fl5qdcjhwnpf4bb44hc5i9pgi-qmapshack-1.11.1.drv', 
'/nix/store/lvkhnlk41wvp3pci17iwyyw1lh8f0m3y-asciidoctor-1.5.6.2.drv', 
'/nix/store/pfy6dgjn6z6x1388zpzwc1af4r0dj7m5-esh-0.1.1.drv', 
'/nix/store/q7p8g4j754l6qdb8pg0q5zzjgxsg0xsw-swift-im-4.0.2.drv', 
'/nix/store/qxc6wsz9v0qd6jpd9vdclqjprqjhr04r-frab-2016-12-28.drv', 
'/nix/store/rq5x345pwcn495a4hsvhw5rprlvpp7d8-wsjtx-1.9.1.drv', 
'/nix/store/s7qgzv9i6j0kj227rzdw85l2abgw9x4k-leo-editor-5.6.drv', 
'/nix/store/w9gmgbqz3zg1322cvgj8ffgv0fm4lz7c-gnome-control-center-3.28.2.drv', 
'/nix/store/wlcmxrs89aa409w19lbfd0agi7brl2vi-qt-full-5.9.3.drv', 
'/nix/store/x635hp1nn6caqk3w0y7r4xy6smjl5hkv-cutegram-2.7.1.drv', 
'/nix/store/zq87rmff7vlinjczpkz6ws6y1cssvcks-psi-plus-1.2.235.drv'
failed

The invocation of 'nix-shell --no-out-link --keep-going --max-jobs 12 --option build-use-sandbox true --run true -p kdeApplications.kontact -p eclipses.eclipse-modeling-36 -p eclipses.eclipse-cpp -p gnome3.gnome-terminal -p gitAndTools.darcsToGit -p plasma5.kmenuedit -p python27Packages.notmuch -p empathy -p eclipses.eclipse-sdk-37 -p blink -p ppl-address-book -p oxidized -p qmc2 -p usbguard -p goldendict -p flent -p bcat
-p calibre -p ruby-zoom -p redmine -p wings -p zfstools -p gollum -p wineWowPackages.full -p vulnix -p luxcorerender -p fpm -p pt -p kmenuedit -p gnome3.file-roller -p alot -p matter-compiler -p mruby -p kdeApplications.kaddressbook -p kdeApplications.akonadiconsole -p hue-cli -p kontact -p quodlibet-without-gst-plugins -p qt59.full -p scallion -p marble -p remmina -p copyq -p riemann-dash -p gmailieer -p plasma-desktop -p gnome3.evolution-data-server -p numix-solarized-gtk-theme -p rubocop -p gnome3.gnome-music -p python36Packages.qtconsole -p quodlibet-xine-full -p pws -p gitAndTools.bitbucket-server-cli -p haskellPackages.hruby -p electrum-ltc -p psi-plus -p python36Packages.pymc3 -p gnome3.yelp -p teamviewer -p luakit -p flock -p doing -p lolcat -p bundler -p areca -p python36Packages.TheanoWithoutCuda -p sensu -p mailcatcher -p libwhereami -p hss -p balsa -p neovim-qt -p grafana -p ruby -p gnome3.gnome-user-docs -p mythtv -p protonmail-bridge -p tmuxinator -p akregator -p leksah -p qt59.qtwebkit -p gitlab-shell -p leo-editor -p plasma5.plasma-workspace -p gnome3.gnome-contacts -p python36Packages.Theano -p mpdcron -p gnome3.gnome_session -p xmonad_log_applet -p kdeApplications.messagelib -p gnome3.gfbgraph -p ec2_ami_tools -p eclipses.eclipse-cpp-37 -p
eclipses.eclipse-sdk-48 -p plover.dev -p shotwell -p gnome3.gnome-boxes -p gitAndTools.git-cola -p libsForQt5.qtwebkit-plugins -p cadence -p powerdevil -p swift-im -p gnome3.nautilus -p urh -p digikam -p rapid-photo-downloader -p jsduck -p opencl-info -p hiera-eyaml -p python27Packages.pyopencl -p reckon -p watson-ruby -p wine-staging -p merkaartor -p ksysguard -p scudcloud -p python36Packages.pyopencl -p electrum -p sigil -p smtube -p kdeApplications.kmail -p plasma5.libksysguard -p afew -p roundup -p nmapsi4 -p neomutt -p kdenlive -p gitlab -p python36Packages.notmuch -p elm-github-install -p wsjtx -p lvmsync -p chromium -p gnome3.gnome-user-share -p deja-dup -p xiphos -p notmuch -p k3b -p krop -p hashcat -p kdeApplications.kdepim-addons -p toggldesktop -p plasma-vault -p facter -p ronn -p gnome3.gnome-shell -p eclipses.eclipse-platform-47 -p rake -p espeak -p python36Packages.TheanoWithCuda -p gnome3.gnome-flashback -p zerotierone -p html-proofer -p liferea -p python27Packages.alot -p nixnote2 -p orca -p plasma5.kdeplasma-addons -p gnome-builder -p espeak-ng -p hplipWithPlugin -p cbor-diag -p papertrail -p gnome3.libgepub -p tmate -p procodile -p wine -p sonic-pi -p clblas -p fast-cli -p greybird -p p4v -p qt56.qtwebkit -p cpp-hocon -p phantomjs2 -p notepadqq -p libsForQt511.qtwebkit-plugins -p tribler -p riemann-tools -p surf -p sass -p spyder -p eclipses.eclipse-platform-46 -p brakeman -p epiphany -p vimPlugins.pluginnames2nix -p quiterss -p gnome3.gnome-control-center -p qpid-cpp -p winetricks -p drake -p kexi -p chrome-gnome-shell -p gnome3.devhelp -p python36Packages.jupyter -p vimb-unwrapped -p ocl-icd -p plasma5.ksysguard -p kdeApplications.akonadi-import-wizard -p
python27Packages.TheanoWithCuda -p sleepyhead -p gnome3.gnome-tweak-tool -p kdeApplications.mailcommon -p golden-cheetah -p consul-ui -p vagrant -p python27Packages.poppler-qt5 -p qt511.qtwebkit -p python27Packages.reikna -p kde-cli-tools -p apitrace -p gnome3.folks -p chefdk -p qt5.full -p google-musicmanager -p mkvtoolnix -p kdeApplications.kalarm -p adapta-gtk-theme -p plasma5.systemsettings -p eclipses.eclipse-platform -p gnome3.empathy -p gnome3.cheese -p gnome3.gvfs -p eclipses.eclipse_modeling_36 -p ocl-icd-oclh_2_2 -p eclipses.eclipse_sdk_37 -p gnome3.evolution_data_server -p r10k -p direwolf -p gnome3.evolution -p gitAndTools.git-annex-metadata-gui -p python36Packages.uranium -p quodlibet -p pipelight -p libsForQt511.libksysguard -p gnome3.gnome-online-accounts -p tuxguitar -p solargraph -p python27Packages.pyqt5 -p terraform-landscape -p google-chrome-dev -p eclipses.eclipse-modeling-47 -p gist -p qarte -p plasma-workspace -p muchsync -p ekiga -p gnome3.grilo-plugins -p libsForQt511.khotkeys -p vimPlugins.command-t -p esh -p vimPlugins.command_T -p asciidoctor -p qmapshack -p eclipses.eclipse-cpp-47 -p gthumb -p cb2bib -p gnome3.geary -p gitAndTools.hub -p ocl-icd-oclh_1_2 -p playonlinux -p owncloud-client -p quodlibet-xine -p gnome3.gnome-maps -p
gnome3.gnome-todo -p google-chrome-beta -p font-manager -p libsForQt5.khotkeys -p feedreader -p kaddressbook -p kdeApplications.mbox-importer -p rubyripper -p azureus -p gnome3.gnome-session -p rstudioWrapper -p systemsettings -p kdeplasma-addons -p eclipses.eclipse-modeling -p cide -p gnome3.gnome_terminal -p notmuch-addrlookup -p nagstamon -p shotcut -p libsForQt5.libksysguard -p beignet -p osmo -p osquery -p plasma5.plasma-vault -p kdeFrameworks.kdewebkit -p t -p gnome3.gnome-photos -p sqlint -p gitaly -p foreman -p cura -p nextcloud-client -p plasma5.plasma-desktop -p blender -p gnome3.gnome-tweaks -p eclipses.eclipse_cpp_37 -p eplot -p openshot-qt -p inav -p gnome3.shotwell -p leatherman -p calligra -p quodlibet-full -p supercollider_scel -p svn2git -p libsForQt5.kreport -p eclipses.eclipse-scala-sdk-441 -p jekyll -p cddl -p kmymoney -p eclipses.eclipse-platform-48 -p python27Packages.TheanoWithoutCuda -p apmplanner2 -p cl -p ocserv -p gnucash -p gnome3.gnome-panel -p haskellPackages.webkit2gtk3-javascriptcore -p plasma5.powerdevil -p supercollider -p astroid -p puppet-lint -p gnome3.gnome_online_accounts -p metasploit -p kdeApplications.kdenlive -p hplip -p vimHugeX -p gns3-gui -p vcsh -p mikutter -p electron-cash -p frescobaldi -p gnome3.gnome-documents -p evolution-data-server -p python27Packages.libgpuarray -p kdeApplications.marble -p ejabberd -p ghostwriter -p multibootusb -p kdeApplications.pim-data-exporter -p tlaplusToolbox -p libsForQt511.kreport -p eclipses.eclipse-scala-sdk -p uim -p gnome3.bijiben -p zeal -p vim_configurable -p python27Packages.qtconsole -p gitAndTools.git-fame -p mate.mate-user-guide -p rednotebook -p ihaskell -p gnome3.totem -p python27Packages.jupyter -p libgdata -p numix-gtk-theme -p travis -p styx -p onboard -p rambox -p vuze -p git-cola -p rstudio -p bundix -p munin -p musescore -p gnome3.gnome-calendar -p gnome3.pomodoro -p python36Packages.reikna -p kmail -p winePackages.full -p gnome3.gnome-applets -p compactor -p gnome3.libzapojit -p pybitmessage -p mnemosyne -p ledger-web -p gnome3.gnome_shell -p midori-unwrapped -p maphosts -p plasma5.khotkeys -p
gnome3.gpaste -p weechat -p python36Packages.sasmodels -p compass -p fastlane -p qutebrowser -p xmr-stak -p ddar -p speechd -p python36Packages.libgpuarray -p trojita -p manuskript -p homesick -p eclipses.eclipse-sdk-46 -p corundum -p darktable -p kdeApplications.k3b -p qt5.qtwebkit -p frab -p gnome3.california -p yelp -p gnome3.libgdata -p python27Packages.sasmodels -p gnome3.epiphany -p eclipses.eclipse-sdk-47 -p python27Packages.Theano -p gnome3.tracker-miners -p swt -p kdeApplications.akregator -p gnome3.orca -p timetrap -p cucumber -p geteltorito -p google-chrome -p gnome3.sushi -p gnome3.gnome_control_center -p python36Packages.poppler-qt5 -p eolie -p qt5Full -p plasma5.kde-cli-tools -p python27Packages.weboob -p subsurface -p cutegram -p mendeley -p fluentd -p qt56.full -p kdevelop -p python27Packages.Lasagne -p eclipses.eclipse-sdk
-p python36Packages.pyqt5 -p gnome3.gnome-online-miners -p opensubdiv -p navit -p nix-top -p qtikz -p driversi686Linux.beignet -p gitAndTools.svn2git -p mkvtoolnix-cli -p qt511.full' failed
Your NIX_PATH still points to the merged pull requests, so you can make attempts to fix it and rerun the command above

Unrelated `nix-review` failure

$ bash
WARNING: bad ownership on /nix/var/nix/profiles/per-user/
ln: failed to create symbolic link '/.nix-profile': Permission denied
WARNING: bad ownership on /nix/var/nix/gcroots/per-user/
mkdir: cannot create directory ‘/.nix-defexpr’: Permission denied
ln: failed to create symbolic link '/.nix-defexpr/channels_root': No such file or directory
open terminal failed: terminal does not support clear
$ git worktree prune
Traceback (most recent call last):
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/review.py", line 159, in build_in_path
    sh(command, cwd=result_dir)
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/utils.py", line 7, in sh
    subprocess.check_call(command, cwd=cwd)
  File "/nix/store/pz8nl4cnppd3p1cykshcb40mqxjd5yvy-python3-3.6.5/lib/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['nix-shell', '--no-out-link', '--keep-going', '--max-jobs', '12', '--option', 'build-use-sandbox', 'true', '--run', 'true', '-p', 'kdeApplications.kontact', '-p', 'eclipses.eclipse-modeling-36', '-p', 'eclipses.eclipse-cpp', '-p', 'gnome3.gnome-terminal', '-p', 'gitAndTools.darcsToGit', '-p', 'plasma5.kmenuedit', '-p', 'python27Packages.notmuch', '-p', 'empathy', '-p', 'eclipses.eclipse-sdk-37', '-p', 'blink', '-p', 'ppl-address-book', '-p', 'oxidized', '-p', 'qmc2', '-p', 'usbguard', '-p', 'goldendict', '-p', 'flent', '-p', 'bcat', '-p', 'calibre', '-p', 'ruby-zoom', '-p', 'redmine', '-p', 'wings', '-p', 'zfstools', '-p', 'gollum', '-p', 'wineWowPackages.full', '-p', 'vulnix', '-p', 'luxcorerender', '-p', 'fpm', '-p', 'pt', '-p', 'kmenuedit', '-p', 'gnome3.file-roller', '-p', 'alot', '-p', 'matter-compiler', '-p', 'mruby', '-p', 'kdeApplications.kaddressbook', '-p', 'kdeApplications.akonadiconsole', '-p', 'hue-cli', '-p', 'kontact', '-p', 'quodlibet-without-gst-plugins', '-p', 'qt59.full', '-p', 'scallion', '-p', 'marble', '-p', 'remmina', '-p', 'copyq', '-p', 'riemann-dash', '-p', 'gmailieer', '-p', 'plasma-desktop', '-p', 'gnome3.evolution-data-server', '-p', 'numix-solarized-gtk-theme', '-p', 'rubocop', '-p', 'gnome3.gnome-music', '-p', 'python36Packages.qtconsole', '-p', 'quodlibet-xine-full', '-p', 'pws', '-p', 'gitAndTools.bitbucket-server-cli', '-p', 'haskellPackages.hruby', '-p', 'electrum-ltc', '-p', 'psi-plus', '-p', 'python36Packages.pymc3', '-p', 'gnome3.yelp', '-p', 'teamviewer', '-p', 'luakit', '-p', 'flock', '-p', 'doing', '-p', 'lolcat', '-p', 'bundler', '-p', 'areca', '-p', 'python36Packages.TheanoWithoutCuda', '-p',
'sensu', '-p', 'mailcatcher', '-p', 'libwhereami', '-p', 'hss', '-p', 'balsa', '-p', 'neovim-qt', '-p', 'grafana', '-p', 'ruby', '-p', 'gnome3.gnome-user-docs', '-p', 'mythtv', '-p', 'protonmail-bridge', '-p', 'tmuxinator', '-p', 'akregator', '-p', 'leksah', '-p', 'qt59.qtwebkit', '-p', 'gitlab-shell', '-p', 'leo-editor', '-p', 'plasma5.plasma-workspace', '-p', 'gnome3.gnome-contacts', '-p', 'python36Packages.Theano', '-p', 'mpdcron', '-p', 'gnome3.gnome_session', '-p', 'xmonad_log_applet', '-p', 'kdeApplications.messagelib', '-p', 'gnome3.gfbgraph', '-p', 'ec2_ami_tools', '-p', 'eclipses.eclipse-cpp-37', '-p', 'eclipses.eclipse-sdk-48', '-p', 'plover.dev', '-p', 'shotwell', '-p', 'gnome3.gnome-boxes', '-p', 'gitAndTools.git-cola', '-p', 'libsForQt5.qtwebkit-plugins', '-p', 'cadence', '-p', 'powerdevil', '-p', 'swift-im', '-p', 'gnome3.nautilus', '-p', 'urh', '-p', 'digikam', '-p', 'rapid-photo-downloader', '-p', 'jsduck', '-p', 'opencl-info', '-p', 'hiera-eyaml', '-p', 'python27Packages.pyopencl', '-p', 'reckon', '-p', 'watson-ruby', '-p', 'wine-staging', '-p', 'merkaartor', '-p', 'ksysguard', '-p', 'scudcloud', '-p', 'python36Packages.pyopencl', '-p', 'electrum', '-p', 'sigil', '-p', 'smtube', '-p', 'kdeApplications.kmail', '-p', 'plasma5.libksysguard', '-p', 'afew', '-p', 'roundup', '-p', 'nmapsi4', '-p', 'neomutt', '-p', 'kdenlive', '-p', 'gitlab', '-p', 'python36Packages.notmuch', '-p', 'elm-github-install', '-p', 'wsjtx', '-p', 'lvmsync', '-p', 'chromium', '-p', 'gnome3.gnome-user-share', '-p', 'deja-dup', '-p', 'xiphos', '-p', 'notmuch', '-p', 'k3b', '-p', 'krop', '-p', 'hashcat', '-p', 'kdeApplications.kdepim-addons', '-p', 'toggldesktop', '-p', 'plasma-vault', '-p',
'facter', '-p', 'ronn', '-p', 'gnome3.gnome-shell', '-p', 'eclipses.eclipse-platform-47', '-p', 'rake', '-p', 'espeak', '-p', 'python36Packages.TheanoWithCuda', '-p', 'gnome3.gnome-flashback', '-p', 'zerotierone', '-p', 'html-proofer', '-p', 'liferea', '-p', 'python27Packages.alot', '-p', 'nixnote2', '-p', 'orca', '-p', 'plasma5.kdeplasma-addons', '-p', 'gnome-builder', '-p', 'espeak-ng', '-p', 'hplipWithPlugin', '-p', 'cbor-diag', '-p', 'papertrail', '-p', 'gnome3.libgepub', '-p', 'tmate', '-p', 'procodile', '-p', 'wine', '-p', 'sonic-pi', '-p', 'clblas', '-p', 'fast-cli', '-p', 'greybird', '-p', 'p4v', '-p', 'qt56.qtwebkit', '-p', 'cpp-hocon', '-p', 'phantomjs2', '-p', 'notepadqq', '-p', 'libsForQt511.qtwebkit-plugins', '-p', 'tribler', '-p', 'riemann-tools', '-p', 'surf', '-p', 'sass', '-p', 'spyder', '-p', 'eclipses.eclipse-platform-46', '-p', 'brakeman', '-p', 'epiphany', '-p', 'vimPlugins.pluginnames2nix', '-p', 'quiterss', '-p', 'gnome3.gnome-control-center', '-p', 'qpid-cpp', '-p', 'winetricks', '-p', 'drake', '-p', 'kexi', '-p', 'chrome-gnome-shell', '-p', 'gnome3.devhelp', '-p', 'python36Packages.jupyter', '-p', 'vimb-unwrapped', '-p', 'ocl-icd', '-p', 'plasma5.ksysguard', '-p', 'kdeApplications.akonadi-import-wizard', '-p', 'python27Packages.TheanoWithCuda', '-p', 'sleepyhead', '-p', 'gnome3.gnome-tweak-tool', '-p', 'kdeApplications.mailcommon', '-p', 'golden-cheetah', '-p', 'consul-ui', '-p', 'vagrant', '-p', 'python27Packages.poppler-qt5', '-p', 'qt511.qtwebkit', '-p', 'python27Packages.reikna', '-p', 'kde-cli-tools', '-p', 'apitrace', '-p', 'gnome3.folks', '-p', 'chefdk', '-p', 'qt5.full', '-p', 'google-musicmanager', '-p', 'mkvtoolnix', '-p', 'kdeApplications.kalarm', '-p', 'adapta-gtk-theme', '-p', 'plasma5.systemsettings', '-p', 'eclipses.eclipse-platform', '-p', 'gnome3.empathy', '-p', 'gnome3.cheese', '-p', 'gnome3.gvfs', '-p', 'eclipses.eclipse_modeling_36', '-p', 'ocl-icd-oclh_2_2', '-p', 'eclipses.eclipse_sdk_37', '-p', 'gnome3.evolution_data_server', '-p', 'r10k', '-p', 'direwolf', '-p', 'gnome3.evolution', '-p', 'gitAndTools.git-annex-metadata-gui', '-p', 'python36Packages.uranium', '-p', 'quodlibet', '-p', 'pipelight', '-p', 'libsForQt511.libksysguard', '-p', 'gnome3.gnome-online-accounts', '-p', 'tuxguitar', '-p', 'solargraph', '-p', 'python27Packages.pyqt5', '-p', 'terraform-landscape', '-p', 'google-chrome-dev', '-p', 'eclipses.eclipse-modeling-47', '-p', 'gist', '-p', 'qarte', '-p', 'plasma-workspace', '-p', 'muchsync', '-p', 'ekiga', '-p', 'gnome3.grilo-plugins', '-p', 'libsForQt511.khotkeys', '-p', 'vimPlugins.command-t', '-p', 'esh', '-p', 'vimPlugins.command_T', '-p', 'asciidoctor', '-p', 'qmapshack', '-p', 'eclipses.eclipse-cpp-47', '-p', 'gthumb', '-p', 'cb2bib', '-p', 'gnome3.geary', '-p', 'gitAndTools.hub', '-p', 'ocl-icd-oclh_1_2', '-p', 'playonlinux', '-p', 'owncloud-client', '-p', 'quodlibet-xine', '-p', 'gnome3.gnome-maps', '-p', 'gnome3.gnome-todo', '-p', 'google-chrome-beta', '-p', 'font-manager', '-p', 'libsForQt5.khotkeys', '-p', 'feedreader', '-p', 'kaddressbook', '-p', 'kdeApplications.mbox-importer', '-p', 'rubyripper', '-p', 'azureus', '-p', 'gnome3.gnome-session', '-p', 'rstudioWrapper', '-p', 'systemsettings', '-p', 'kdeplasma-addons', '-p', 'eclipses.eclipse-modeling', '-p', 'cide', '-p', 'gnome3.gnome_terminal', '-p', 'notmuch-addrlookup', '-p', 'nagstamon', '-p', 'shotcut', '-p', 'libsForQt5.libksysguard', '-p', 'beignet', '-p', 'osmo', '-p', 'osquery', '-p', 'plasma5.plasma-vault', '-p', 'kdeFrameworks.kdewebkit', '-p', 't', '-p', 'gnome3.gnome-photos', '-p', 'sqlint', '-p', 'gitaly', '-p', 'foreman', '-p', 'cura', '-p', 'nextcloud-client', '-p', 'plasma5.plasma-desktop', '-p', 'blender', '-p', 'gnome3.gnome-tweaks', '-p', 'eclipses.eclipse_cpp_37', '-p', 'eplot', '-p', 'openshot-qt', '-p', 'inav', '-p', 'gnome3.shotwell', '-p', 'leatherman', '-p', 'calligra', '-p', 'quodlibet-full', '-p', 'supercollider_scel', '-p', 'svn2git', '-p', 'libsForQt5.kreport', '-p', 'eclipses.eclipse-scala-sdk-441', '-p', 'jekyll', '-p', 'cddl', '-p', 'kmymoney', '-p', 'eclipses.eclipse-platform-48', '-p', 'python27Packages.TheanoWithoutCuda', '-p', 'apmplanner2', '-p', 'cl', '-p', 'ocserv', '-p', 'gnucash', '-p', 'gnome3.gnome-panel', '-p', 'haskellPackages.webkit2gtk3-javascriptcore', '-p', 'plasma5.powerdevil', '-p', 'supercollider', '-p', 'astroid', '-p', 'puppet-lint', '-p', 'gnome3.gnome_online_accounts', '-p', 'metasploit', '-p', 'kdeApplications.kdenlive', '-p', 'hplip', '-p', 'vimHugeX', '-p', 'gns3-gui', '-p', 'vcsh', '-p', 'mikutter', '-p', 'electron-cash', '-p', 'frescobaldi', '-p', 'gnome3.gnome-documents', '-p', 'evolution-data-server', '-p', 'python27Packages.libgpuarray', '-p', 'kdeApplications.marble', '-p', 'ejabberd', '-p', 'ghostwriter', '-p', 'multibootusb', '-p', 'kdeApplications.pim-data-exporter', '-p', 'tlaplusToolbox', '-p', 'libsForQt511.kreport', '-p', 'eclipses.eclipse-scala-sdk', '-p', 'uim', '-p', 'gnome3.bijiben', '-p', 'zeal', '-p', 'vim_configurable', '-p', 'python27Packages.qtconsole', '-p', 'gitAndTools.git-fame', '-p', 'mate.mate-user-guide', '-p', 'rednotebook', '-p', 'ihaskell', '-p', 'gnome3.totem', '-p', 'python27Packages.jupyter', '-p', 'libgdata', '-p', 'numix-gtk-theme', '-p', 'travis', '-p', 'styx', '-p', 'onboard', '-p', 'rambox', '-p', 'vuze', '-p', 'git-cola', '-p', 'rstudio', '-p', 'bundix', '-p', 'munin', '-p', 'musescore', '-p', 'gnome3.gnome-calendar', '-p', 'gnome3.pomodoro', '-p', 'python36Packages.reikna', '-p', 'kmail', '-p', 'winePackages.full',
'-p', 'gnome3.gnome-applets', '-p', 'compactor', '-p', 'gnome3.libzapojit', '-p', 'pybitmessage', '-p', 'mnemosyne', '-p', 'ledger-web', '-p', 'gnome3.gnome_shell', '-p', 'midori-unwrapped', '-p', 'maphosts', '-p', 'plasma5.khotkeys', '-p', 'gnome3.gpaste', '-p', 'weechat', '-p', 'python36Packages.sasmodels', '-p', 'compass', '-p', 'fastlane', '-p', 'qutebrowser', '-p', 'xmr-stak', '-p', 'ddar', '-p', 'speechd', '-p', 'python36Packages.libgpuarray', '-p', 'trojita', '-p', 'manuskript', '-p', 'homesick', '-p', 'eclipses.eclipse-sdk-46', '-p', 'corundum', '-p', 'darktable', '-p', 'kdeApplications.k3b', '-p', 'qt5.qtwebkit', '-p', 'frab', '-p', 'gnome3.california', '-p', 'yelp', '-p', 'gnome3.libgdata', '-p', 'python27Packages.sasmodels', '-p', 'gnome3.epiphany', '-p', 'eclipses.eclipse-sdk-47', '-p', 'python27Packages.Theano', '-p', 'gnome3.tracker-miners', '-p', 'swt', '-p', 'kdeApplications.akregator', '-p', 'gnome3.orca', '-p', 'timetrap', '-p', 'cucumber', '-p', 'geteltorito', '-p', 'google-chrome', '-p', 'gnome3.sushi', '-p', 'gnome3.gnome_control_center', '-p', 'python36Packages.poppler-qt5', '-p', 'eolie', '-p', 'qt5Full', '-p', 'plasma5.kde-cli-tools', '-p', 'python27Packages.weboob', '-p', 'subsurface', '-p', 'cutegram', '-p', 'mendeley', '-p', 'fluentd', '-p', 'qt56.full', '-p', 'kdevelop', '-p', 'python27Packages.Lasagne', '-p', 'eclipses.eclipse-sdk', '-p', 'python36Packages.pyqt5', '-p', 'gnome3.gnome-online-miners', '-p', 'opensubdiv', '-p', 'navit', '-p', 'nix-top', '-p', 'qtikz', '-p', 'driversi686Linux.beignet', '-p', 'gitAndTools.svn2git', '-p', 'mkvtoolnix-cli', '-p', 'qt511.full']' returned non-zero exit status 100.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/bin/..nix-review-wrapped-wrapped", line 12, in <module>
    sys.exit(main())
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/__init__.py", line 10, in main
    app.main(command, args)
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/app.py", line 135, in main
    args.func(args)
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/app.py", line 46, in pr_command
    _pr_command(prs, args.build_args, args.token)
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/app.py", line 35, in _pr_command
    attrs = r.build_pr(pr)
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/review.py", line 69, in build_pr
    return build_in_path(self.worktree_dir, packages, self.build_args)
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/review.py", line 167, in build_in_path
    sh(["bash"], cwd=result_dir)
  File "/nix/store/vyc91jp4i0g2lnr3xnir0cgcvraqra9q-nix-review-0.3.0/lib/python3.6/site-packages/nix_review/utils.py", line 7, in sh
    subprocess.check_call(command, cwd=cwd)
  File "/nix/store/pz8nl4cnppd3p1cykshcb40mqxjd5yvy-python3-3.6.5/lib/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['bash']' returned non-zero exit status 1.
Command exited with non-zero status 1

[Mic92]

nix-review needs markdown output!

[manveru]

So this depends on #45780 which should fix most of the failures.

[samueldr]

I haven't looked at existing failures, and haven't looked at the logs, but the build just finished with those failures, when merging your branch into current nixpkgs-unstable (254bb9d)

• https://gist.github.com/samueldr/4958b74e32c4aeb5044034a26b5b1d8b

This is raw data, I'm off and will be checking this during the following day if you haven't already by the time I come to that.

[Mic92]

I went over the list and it seems that the upgrade did not introduce any regressions for us.