New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
et-book: init at 1.0 #46471
et-book: init at 1.0 #46471
Conversation
pkgs/data/fonts/et-book/default.nix
Outdated
{ stdenv, fetchFromGitHub }: | ||
|
||
fetchFromGitHub rec { | ||
rev = "1.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since upstream is not versioned, this should be 2018-09-10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using the rev string instead, would that be okay?
pkgs/data/fonts/et-book/default.nix
Outdated
fetchFromGitHub rec { | ||
rev = "1.0"; | ||
name = "et-book-${rev}"; | ||
owner = "jethrokuan"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should point to original repository from edwardtufte https://github.com/edwardtufte/et-book/tree/gh-pages/source/4-ttf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 my nix-fu wasn't strong enough when I packaged it then, let me know if there's a better way to package it now
@marsam anything else to change? |
Motivation for this change
ET Bembo is a relatively popular font, surprised to see it yet to be packaged in Nixpkgs. The revision given is bogus, this font has not been updated for many years.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)