dart: 1.24.3 -> 2.0.0 #46526
dart: 1.24.3 -> 2.0.0 #46526
Conversation
Added the link to the new dart sdk stable. Forgot semicolons.
|
Thank you for the contribution! Could you please adjust the commit message to match our usual format? The CONTRIBUTING.md describes that in detail: https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes |
|
dart = callPackage ../development/interpreters/dart { };
dart_stable = dart.override { version = "1.24.3"; };
dart_old = dart.override { version = "1.16.1"; };
dart_dev = dart.override { version = "2.0.0-dev.26.0"; };Could you please update them according the version change? |
| @@ -25,6 +25,14 @@ let | |||
| url = "${stable}/${version}/sdk/dartsdk-linux-ia32-release.zip"; | |||
| sha256 = "d67b8f8f9186e7d460320e6bce25ab343c014b6af4b2f61369ee83755d4da528"; | |||
| }; | |||
| "2.0.0-x86_64-linux" = fetchurl { | |||
| url = "{$stable}/${version}/sdk/dartsdk-linux-x64-release.zip"; | |||
There was a problem hiding this comment.
You have a small syntax error there ;)
The $ of the stable part isn't where it should be.
| sha256 = "4014a1e8755d2d32cc1573b731a4a53acdf6dfca3e26ee437f63fe768501d336"; | ||
| }; | ||
| "2.0.0-i686-linux" = fetchurl { | ||
| url = "{$stable}/${version}/sdk/dartsdk-linux-ia32-release.zip"; |
There was a problem hiding this comment.
sorry for causing so many problems with this, it's been a little hectic not being able to fix things because my internet is spotty right now
There was a problem hiding this comment.
Thais all right. just take your time.
moved dollar sign
changed dart version numbers
|
Done. |
|
Is there anything else that needs to be done? |
|
The commits still have the wrong messages. |
Motivation for this change
The Dart VM supplied by nixpkgs has been outdated for quite a while, and needed to be updated.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)