Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: 0.16.1 -> 0.17.1 #46700

Merged
merged 1 commit into from Sep 17, 2018
Merged

bazel: 0.16.1 -> 0.17.1 #46700

merged 1 commit into from Sep 17, 2018

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Sep 15, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

Do not merge before #46699 is merged. I will rebase this PR once that one is in master.

This should go to staging as it's a mass rebuild. I'll mark it as WIP until the other PR is merged.

@Mic92 Mic92 changed the title bazel: update to 0.17.1 bazel: 0.16.1 -> 0.17.1 Sep 15, 2018
@uri-canva
Copy link
Contributor Author

@xeji Changed this PR to not depend on #46699.

@xeji
Copy link
Contributor

xeji commented Sep 16, 2018

@GrahamcOfBorg build bazel

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bazel

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bazel

Partial log (click to expand)

//examples/java-native/src/test/java/com/example/myproject:hello         PASSED in 0.3s

Executed 2 out of 2 tests: 2 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 21 total actions
installing
post-installation fixup
patching script interpreter paths in /nix/store/pgx85qfcdkyh8836xcw1wg5hq7nz8v8g-bazel-0.17.1
checking for references to /tmp/.bazel-1000 in /nix/store/pgx85qfcdkyh8836xcw1wg5hq7nz8v8g-bazel-0.17.1...
/nix/store/pgx85qfcdkyh8836xcw1wg5hq7nz8v8g-bazel-0.17.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bazel

Partial log (click to expand)

//examples/cpp:hello-success_test                                        PASSED in 0.2s
//examples/java-native/src/test/java/com/example/myproject:hello         PASSED in 0.5s

Executed 2 out of 2 tests: 2 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
INFO: Build completed successfully, 19 total actions
installing
post-installation fixup
patching script interpreter paths in /nix/store/yziylmm7zinsgx7xd6fwf1ma0jczhjgi-bazel-0.17.1
/nix/store/yziylmm7zinsgx7xd6fwf1ma0jczhjgi-bazel-0.17.1

@xeji
Copy link
Contributor

xeji commented Sep 16, 2018

cc @mboes @Profpatsch

@Profpatsch
Copy link
Member

Profpatsch commented Sep 17, 2018

Works fine, successfully ran all rules_haskell tests with the new version (not representative of course).

Thanks for the bump!

@Profpatsch Profpatsch merged commit 61dbb0c into NixOS:master Sep 17, 2018
@uri-canva uri-canva deleted the bazel_0_17_1 branch September 17, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants