Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devpi-client: 3.1.0 -> 4.1.0, fix tests #47142

Merged
merged 1 commit into from Sep 22, 2018
Merged

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 21, 2018

Motivation for this change

Build failed on Hydra: https://hydra.nixos.org/job/nixpkgs/trunk/devpi-client.x86_64-linux/all
Update to latest version, fix failing tests, reenable a previously disabled test.

ZHF #45960, please backport to 18.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @makefu @nlewo

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: devpi-client

Partial log (click to expand)

SKIP [1] testing/test_list_remove.py:129: devpi-server before 4.6.0 didn't support deleting single release files.
SKIP [1] testing/test_main.py:57: condition: sys.version_info < (3,)

=============================== warnings summary ===============================
<undetermined location>
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: https://docs.pytest.org/en/latest/warnings.html
====== 188 passed, 3 skipped, 1 deselected, 1 warnings in 211.14 seconds =======
/nix/store/ih2c0493sqpcclyv6ga1b805j15dzqnb-devpi-client-4.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: devpi-client

Partial log (click to expand)

SKIP [1] /nix/store/ml2s1hjf20j5h959saf114sd35bhrn0g-devpi-server-4.4.0/lib/python2.7/site-packages/test_devpi_server/functional.py:433: Mapp implementation doesn't have 'get_simple' method.
SKIP [1] testing/test_main.py:57: condition: sys.version_info < (3,)

=============================== warnings summary ===============================
<undetermined location>
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: https://docs.pytest.org/en/latest/warnings.html
====== 188 passed, 3 skipped, 1 deselected, 1 warnings in 233.39 seconds =======
/nix/store/4z6qdr9jcc349zml9y3cyqs0zmnz45cg-devpi-client-4.1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: devpi-client

Partial log (click to expand)

SKIP [1] testing/test_list_remove.py:129: devpi-server before 4.6.0 didn't support deleting single release files.
SKIP [1] testing/test_main.py:57: condition: sys.version_info < (3,)

=============================== warnings summary ===============================
<undetermined location>
  Module already imported so cannot be rewritten: _pytest.pytester

-- Docs: https://docs.pytest.org/en/latest/warnings.html
====== 188 passed, 3 skipped, 1 deselected, 1 warnings in 963.63 seconds =======
/nix/store/sbc86j0ypm7hf8ixchpfy0basss4fgzl-devpi-client-4.1.0

@makefu
Copy link
Contributor

makefu commented Sep 21, 2018

thanks!

@xeji xeji merged commit c770699 into NixOS:master Sep 22, 2018
@xeji xeji deleted the p/devpi-client branch September 22, 2018 16:07
xeji added a commit that referenced this pull request Sep 22, 2018
@xeji
Copy link
Contributor Author

xeji commented Sep 22, 2018

backported: 9e4916b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants