Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renoise: add mpg123 to runtime deps #47435

Merged
merged 2 commits into from Nov 25, 2018
Merged

renoise: add mpg123 to runtime deps #47435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5d3c41
renoise: add mpg123 to runtime deps
Oct 1, 2018
254fd85
renoise: split native build inputs
c0bw3b Nov 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkgs/applications/audio/renoise/default.nix
View file
Open in desktop
@@ -1,4 +1,5 @@
{ stdenv, fetchurl, libX11, libXext, libXcursor, libXrandr, libjack2, alsaLib, releasePath ? null }:
{ stdenv, fetchurl, libX11, libXext, libXcursor, libXrandr, libjack2, alsaLib,
mpg123, makeWrapper, releasePath ? null }:

with stdenv.lib;

Expand Down Expand Up @@ -35,6 +36,7 @@ stdenv.mkDerivation rec {
releasePath
else throw "Platform is not supported by Renoise";

nativeBuildInputs = [ makeWrapper ];
buildInputs = [ libX11 libXext libXcursor libXrandr alsaLib libjack2 ];

installPhase = ''
Expand All @@ -56,11 +58,12 @@ stdenv.mkDerivation rec {
ln -s $out/renoise $out/bin/renoise

patchelf --set-interpreter $(cat $NIX_CC/nix-support/dynamic-linker) --set-rpath $out/lib $out/renoise
Copy link
Member

@Mic92 Mic92 Nov 26, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it uses the binary from mpg123. If it uses a library from that package, it is better to extend the patchelf command above:

patchelf \
   --set-interpreter $(cat $NIX_CC/nix-support/dynamic-linker) \
   --set-rpath $out/lib:${mpg123}/lib \
   $out/renoise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I checked on their forum and it does need libmpg123.so only.
I tested locally and setting the RPATH to include ${mpg123}/lib does the trick
(app still shows File-IO: Enabling MP3 decoding support using system mpg123 library... in its startup logs)

I'll correct this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in af31c4e

wrapProgram "$out/renoise" --prefix LD_LIBRARY_PATH : "${mpg123}/lib"
'';

meta = {
description = "Modern tracker-based DAW";
homepage = http://www.renoise.com/;
homepage = https://www.renoise.com/;
license = licenses.unfree;
maintainers = [];
platforms = [ "i686-linux" "x86_64-linux" ];
Expand Down