Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/roundcube: add roundcube module #47655

Closed
wants to merge 6 commits into from
Closed

nixos/roundcube: add roundcube module #47655

wants to merge 6 commits into from

Conversation

Vskilet
Copy link
Contributor

@Vskilet Vskilet commented Oct 2, 2018

Motivation for this change

I added Roundcube package (#47270) one week ago, so it sound good to have the module to use it 👍
It's my first pull request for a nixos module, so feedbacks are welcome.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Copy link
Member

@globin globin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments and also I'd be happy if you could add a test for it!

nixos/modules/services/mail/roundcube.nix Show resolved Hide resolved
nixos/modules/services/mail/roundcube.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/roundcube.nix Outdated Show resolved Hide resolved
@Vskilet Vskilet closed this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants