WIP emby: 3.5.2.0 -> 3.5.3.0 and migration from mono to dotnet #47659

nyanloutre · 2018-10-02T10:17:39Z

Motivation for this change

Fixes #47658

This release is not available as a mono build, so I tried to make it work with dotnet

Current situation

By launching it manually it seems to be working as it is

Fixed

I didn't manage to make it work yet, if you have any suggestion please make a comment.

Execution of bin/emby for now:

System.DllNotFoundException: Unable to load shared library 'sqlite3' or one of its dependencies.

Previously this was fixed by editing the file SQLitePCLRaw.provider.sqlite3.dll.config, but it is not present anymore and creating it doesn't have any effects.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

baracoder · 2018-10-02T14:47:02Z

pkgs/servers/emby/default.nix

-    mkdir -p "$out/bin"
-    cp -r * "$out/bin"
+    install -dm 755 "$out/usr/lib/emby-server"
+    cp -r * "$out/usr/lib/emby-server"


I suspect this will copy env-vars file to the destination directory, which can contain references to other packages not needed at runtime, similar to #47269

What do you suggest would be appropriate?

In the linked issue, I have changed the unpacking phase to create the expected source directory

unpackPhase = '' mkdir src cd src tar xvzf $src '';

I can't figure out what shouldn't be copied. By inspecting the result simlink it seems that only needed files are here.

I have tested the build and there are no unwanted files in the result directory.
It seams I have misunderstood the origin of the problem in the other issue:
I assumed that the env-vars file is created as part of the setup for every build, but it is not. Also it seams to be not required, that an archive contains a directory for the files first. I will have to look at why it is again.
So I am sorry for adding this confusion.
Edit: 🤦‍♂️ Found my stupid mistake: The new zip file is organized in the expected manner. There is only one subdirectory named system, so everything works out.

nyanloutre · 2018-10-02T21:13:30Z

@baracoder I tried to use coreclr, but corerun doesn't seems to be a drop in replacement of the dotnet executable.

worldofpeace · 2018-10-02T22:23:42Z

pkgs/servers/emby/default.nix

-
-    makeWrapper "${mono54}/bin/mono" $out/bin/MediaBrowser.Server.Mono \
-      --add-flags "$out/bin/MediaBrowser.Server.Mono.exe -ffmpeg ${ffmpeg}/bin/ffmpeg -ffprobe ${ffmpeg}/bin/ffprobe"
+    install -dm 755 "$out/usr/lib/emby-server"


@nyanloutre This path shouldn't have usr/ in the nix store.

Is /lib the correct folder ? I putted it here because it mostly consisted of dll files, but maybe /opt would be better ?

worldofpeace · 2018-10-03T17:34:26Z

Execution of $out/bin/emby now fails with

Unhandled Exception: System.BadImageFormatException: Could not load file or assembly '/nix/store/0cjx8x3y29v6q1bfmxh1w4a8bmd5rfjj-emby-3.5.3.0/lib/emby-server/EmbyServer.dll'. The module was expected to contain an assembly manifest.
Aborted

nyanloutre · 2018-10-04T08:02:36Z

@worldofpeace this is strange, do you have any idea why ? If I revert the commit 9ec17c6 it works again

EDIT: Interestingly if I put the files in /opt it also work

worldofpeace · 2018-10-04T17:34:48Z

@nyanloutre Strange, yet if it works at "$out/opt" then it's good 👍

worldofpeace · 2018-10-04T17:35:03Z

@GrahamcOfBorg build emby

GrahamcOfBorg · 2018-10-04T17:35:16Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: emby

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-04T17:36:22Z

Success on x86_64-linux (full log)

Attempted: emby

Partial log (click to expand)

no configure script, doing nothing
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3cvin3yxq3927md8c4vl961mpsk48ahf-emby-3.5.3.0
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3cvin3yxq3927md8c4vl961mpsk48ahf-emby-3.5.3.0/bin
patching script interpreter paths in /nix/store/3cvin3yxq3927md8c4vl961mpsk48ahf-emby-3.5.3.0
checking for references to /build in /nix/store/3cvin3yxq3927md8c4vl961mpsk48ahf-emby-3.5.3.0...
/nix/store/3cvin3yxq3927md8c4vl961mpsk48ahf-emby-3.5.3.0

worldofpeace

Tested it locally and such and I'm not having any issues so I think this is good.
Just squash into and edit this message WIP emby: 3.5.2.0 -> 3.5.3.0 to emby: 3.5.2.0 -> 3.5.3.0

cc @xeji @timokau

timokau · 2018-10-04T21:07:56Z

Thank you!

Since errors of this kind

Unhandled Exception: System.BadImageFormatException: Could not load file or assembly '/nix/store/0cjx8x3y29v6q1bfmxh1w4a8bmd5rfjj-emby-3.5.3.0/lib/emby-server/EmbyServer.dll'. The module was expected to contain an assembly manifest.
Aborted

seem to be common, it would be nice to add some sort of automatic sanity testing in the future. Something like

installCheckPhase = ''
    $out/bin/emby -v | grep "${version}"
''

nyanloutre · 2018-10-05T06:34:55Z

There should also be a patch to the Emby module because the binary name changed

nixos/emby: fix use of outdated binary name changed by NixOS#47659

(cherry picked from commit bb06b5b)

nyanloutre force-pushed the emby-3.5.3.0 branch from e6ae3ba to 2d9342e Compare October 2, 2018 10:18

WIP emby: 3.5.2.0 -> 3.5.3.0

6e8da1d

nyanloutre force-pushed the emby-3.5.3.0 branch from 2d9342e to 6e8da1d Compare October 2, 2018 10:19

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 2, 2018

emby: add sqlite to wrapper

f7a2e20

baracoder reviewed Oct 2, 2018

View reviewed changes

worldofpeace reviewed Oct 2, 2018

View reviewed changes

emby: move usr/lib to lib

9ec17c6

emby: move lib to opt

c2e269e

worldofpeace approved these changes Oct 4, 2018

View reviewed changes

timokau merged commit 11068c6 into NixOS:master Oct 4, 2018

nyanloutre added a commit to nyanloutre/nixpkgs that referenced this pull request Oct 5, 2018

nixos/emby: fixes binary name change introduced by NixOS#47659

bb06b5b

nyanloutre mentioned this pull request Oct 5, 2018

nixos/emby: fixes binary name change introduced by #47659 #47906

Merged

9 tasks

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 5, 2018

Merge pull request NixOS#47906 from nyanloutre/emby-bin-name-fix

3f98dd1

nixos/emby: fix use of outdated binary name changed by NixOS#47659

Vskilet pushed a commit to Vskilet/nixpkgs that referenced this pull request Oct 12, 2018

nixos/emby: fixes binary name change introduced by NixOS#47659

ca20a04

(cherry picked from commit bb06b5b)

nyanloutre deleted the emby-3.5.3.0 branch October 22, 2018 16:05

nyanloutre added a commit to nyanloutre/nixpkgs that referenced this pull request Oct 22, 2018

nixos/emby: fixes binary name change introduced by NixOS#47659

b806a3d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP emby: 3.5.2.0 -> 3.5.3.0 and migration from mono to dotnet #47659

WIP emby: 3.5.2.0 -> 3.5.3.0 and migration from mono to dotnet #47659

nyanloutre commented Oct 2, 2018 •

edited

baracoder Oct 2, 2018 •

edited

worldofpeace Oct 2, 2018

baracoder Oct 2, 2018 •

edited

nyanloutre Oct 2, 2018

baracoder Oct 2, 2018 •

edited

nyanloutre commented Oct 2, 2018

worldofpeace Oct 2, 2018

nyanloutre Oct 3, 2018

worldofpeace commented Oct 3, 2018

nyanloutre commented Oct 4, 2018 •

edited

worldofpeace commented Oct 4, 2018

worldofpeace commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

worldofpeace left a comment

timokau commented Oct 4, 2018

nyanloutre commented Oct 5, 2018

WIP emby: 3.5.2.0 -> 3.5.3.0 and migration from mono to dotnet #47659

WIP emby: 3.5.2.0 -> 3.5.3.0 and migration from mono to dotnet #47659

Conversation

nyanloutre commented Oct 2, 2018 • edited

Motivation for this change

Current situation

Fixed

Things done

baracoder Oct 2, 2018 • edited

Choose a reason for hiding this comment

worldofpeace Oct 2, 2018

Choose a reason for hiding this comment

baracoder Oct 2, 2018 • edited

Choose a reason for hiding this comment

nyanloutre Oct 2, 2018

Choose a reason for hiding this comment

baracoder Oct 2, 2018 • edited

Choose a reason for hiding this comment

nyanloutre commented Oct 2, 2018

worldofpeace Oct 2, 2018

Choose a reason for hiding this comment

nyanloutre Oct 3, 2018

Choose a reason for hiding this comment

worldofpeace commented Oct 3, 2018

nyanloutre commented Oct 4, 2018 • edited

worldofpeace commented Oct 4, 2018

worldofpeace commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

GrahamcOfBorg commented Oct 4, 2018

worldofpeace left a comment

Choose a reason for hiding this comment

timokau commented Oct 4, 2018

nyanloutre commented Oct 5, 2018

nyanloutre commented Oct 2, 2018 •

edited

baracoder Oct 2, 2018 •

edited

baracoder Oct 2, 2018 •

edited

baracoder Oct 2, 2018 •

edited

nyanloutre commented Oct 4, 2018 •

edited