Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3lock-fancy: unstable-2017-12-14 -> unstable-2018-08-27 #47974

Closed
wants to merge 1 commit into from

Conversation

@jqueiroz
Copy link
Member

jqueiroz commented Oct 6, 2018

Motivation for this change
  • Updates package to a more recent version
  • Man pages are now installed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Oct 8, 2018

@GrahamcOfBorg build i3lock-fancy

@GrahamcOfBorg

This comment has been minimized.

Copy link

GrahamcOfBorg commented Oct 8, 2018

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: i3lock-fancy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg

This comment has been minimized.

Copy link

GrahamcOfBorg commented Oct 8, 2018

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: i3lock-fancy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


pkgs/applications/window-managers/i3/lock-fancy.nix Outdated Show resolved Hide resolved
@GrahamcOfBorg

This comment has been minimized.

Copy link

GrahamcOfBorg commented Oct 8, 2018

Success on x86_64-linux (full log)

Attempted: i3lock-fancy

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd
gzipping man pages under /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd/bin
patching script interpreter paths in /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd
/nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd/bin/i3lock-fancy: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd...
/nix/store/66z7s5az4mfb1sjznwkghh8gzavgdlwx-i3lock-fancy-unstable-2018-08-27_revf2e9bdd

@jqueiroz jqueiroz force-pushed the jqueiroz:i3lock branch Oct 8, 2018
pkgs/applications/window-managers/i3/lock-fancy.nix Outdated Show resolved Hide resolved
@jqueiroz jqueiroz force-pushed the jqueiroz:i3lock branch Oct 9, 2018
@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Oct 12, 2018

@GrahamcOfBorg build i3lock-fancy

@GrahamcOfBorg

This comment has been minimized.

Copy link

GrahamcOfBorg commented Oct 12, 2018

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: i3lock-fancy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg

This comment has been minimized.

Copy link

GrahamcOfBorg commented Oct 12, 2018

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: i3lock-fancy

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg

This comment has been minimized.

Copy link

GrahamcOfBorg commented Oct 12, 2018

Success on x86_64-linux (full log)

Attempted: i3lock-fancy

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27
gzipping man pages under /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27/bin
patching script interpreter paths in /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27
/nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27/bin/i3lock-fancy: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27...
/nix/store/5ik29sgbdn81yga7f4fn9b3d7sprvzv7-i3lock-fancy-unstable-2018-08-27

@jqueiroz jqueiroz force-pushed the jqueiroz:i3lock branch to c6eb2ab Oct 14, 2018
@jqueiroz

This comment has been minimized.

Copy link
Member Author

jqueiroz commented Oct 14, 2018

Just noticed that 'postInstall' was not getting invoked as 'installPhase' is specified, so I replaced it with 'postFixup'.

Copy link
Member

ryantm left a comment

Please fix the merge conflict

@ryantm

This comment has been minimized.

Copy link
Member

ryantm commented Feb 25, 2019

Never mind, it's already on a later version than this entirely. Closing...

@ryantm ryantm closed this Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.