Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

boohu: leave one package #48138

Merged
merged 1 commit into from Oct 10, 2018
Merged

boohu: leave one package #48138

merged 1 commit into from Oct 10, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2018

There will be only one version of the package with
the fewest external dependencies.

Motivation for this change

@Mic92 馃懡
I agree with you and left only one package with the the fewest external dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

There will be only one version of the package with
the fewest external dependencies.
@Mic92
Copy link
Member

Mic92 commented Oct 10, 2018

Thanks

@ghost
Copy link
Author

ghost commented Oct 13, 2018

馃懡 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants