nheko: mark as insecure

[Ekleog]

The package is no longer maintained and includes potential security
vulnerabilities (a use-after-free and several crashes) that are known
and not fixed in the version present in nixpkgs. They don't look too bad
judging from the trigger vectors mentioned in the changelog, but with
the project going unmaintained one of them becoming a security
vulnerability would likely not be noticed.

Backport is in #48280

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[GrahamcOfBorg]

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nheko

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "nheko-0.6.2"
       ];
     }

[GrahamcOfBorg]

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: nheko

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "nheko-0.6.2"
       ];
     }

[xeji]

Makes sense, upstream github repo has archived. This can be reverted later if a maintained fork appears.

[xeji]

backported to 18.09 in 14bb2f4

[dtzWill]

Can you point to any further information about the security / crashes? I see it marked no longer maintained which is a bummer but curious about the rest so I can understand if I need to stop using it or what :).

[Ekleog]

@dtzWill OK, so actually I need to withdraw my point about the use-after-free / crashes: I did not notice you took over maintaining it, and thought it was still at the pre-0.5 version I had left it at (never got to redoing the packaging work after the build system changed, and wasn't notified that someone else had done it :)), so I assumed all the things I was seeing in the changelog were still waiting in nixpkgs. As nothing looked too bad it didn't trigger me to spend an afternoon on re-doing the packaging to the new build system, though :'(

Now, unmaintained packages mostly mean that if there's a security vulnerability found we likely won't know about it, so I'd personally stop using it, but… your pick :)

[dotlambda]

FYI: There is https://github.com/Nheko-Reborn/nheko.

[flokli]

@dotlambda did you or @fpletz already take a spin on updating the derivation to it?