Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libaosd: init at 0.2.7-9-g177589f #48338

Merged
merged 1 commit into from Oct 21, 2018
Merged

libaosd: init at 0.2.7-9-g177589f #48338

merged 1 commit into from Oct 21, 2018

Conversation

unode
Copy link
Member

@unode unode commented Oct 13, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libaosd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f
shrinking /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f/bin/aosd_cat
shrinking /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f/lib/libaosd-text.so.2.0.0
shrinking /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f/lib/libaosd.so.2.0.0
gzipping man pages under /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f/lib  /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f/bin
patching script interpreter paths in /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f
checking for references to /build in /nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f...
/nix/store/rk62ny0bazch34pdf40mi8n2aqipyix5-libaosd-0.2.7-9-g177589f

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libaosd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f
shrinking /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f/lib/libaosd.so.2.0.0
shrinking /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f/lib/libaosd-text.so.2.0.0
shrinking /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f/bin/aosd_cat
gzipping man pages under /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f/lib  /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f/bin
patching script interpreter paths in /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f
checking for references to /build in /nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f...
/nix/store/0935ynarfhyljshdrn4488pma2bcdkla-libaosd-0.2.7-9-g177589f

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2018

Forgive my question, but since this library is unmaintained and already legacy (last commit in 2011), is it really worth adding it to <nixpkgs> now?

If you have a private use for it, you could build it locally and push it on Cachix.
Or maybe you intended to package something later that would depend on this?

I'm genuinely curious here, not trying to imply this should be turned down just because it's old
(although it is quite old 🐼 )

@unode
Copy link
Member Author

unode commented Oct 21, 2018

Hi Renaud, Yes I am using it and since it worked out of the box with minimal effort I found no reason not to include it in nixpkgs. It's present in other distros and some software builds on it.

I don't think age should be a major blocker as long as it works. Which is to say that if something does break and is not easily fixed, it would be a candidate for removal. For now it's all in the green.

I also saw that there are aosd haskell bindings in nixpkgs but I didn't find a standalone libaosd.

c0bw3b
c0bw3b requested changes Oct 21, 2018
View reviewed changes
pkgs/development/libraries/libaosd/default.nix Outdated
sha256 = "1cn7k0n74p6jp25kxwcyblhmbdvgw3mikvj0m2jh4c6xccfrgb9a";
};

buildInputs = [autoconf automake pkgconfig cairo pango libX11 libXcomposite];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [autoconf automake pkgconfig cairo pango libX11 libXcomposite];
nativeBuildInputs = [ autoconf automake pkgconfig ];
buildInputs = [ cairo pango libX11 libXcomposite ];
enableParallelBuilding = true;

pkgs/development/libraries/libaosd/default.nix Outdated

buildInputs = [autoconf automake pkgconfig cairo pango libX11 libXcomposite];

prePatch = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prePatch = ''
preConfigure = ''

would be more sensible

@unode
Copy link
Member Author

unode commented Oct 21, 2018

Changes implemented

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libaosd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f
shrinking /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f/bin/aosd_cat
shrinking /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f/lib/libaosd-text.so.2.0.0
shrinking /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f/lib/libaosd.so.2.0.0
gzipping man pages under /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f/lib  /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f/bin
patching script interpreter paths in /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f
checking for references to /build in /nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f...
/nix/store/4ybjwp9k8pagjq429dipv8qdsvbmi2w0-libaosd-0.2.7-9-g177589f

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libaosd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f
shrinking /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f/bin/aosd_cat
shrinking /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f/lib/libaosd-text.so.2.0.0
shrinking /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f/lib/libaosd.so.2.0.0
gzipping man pages under /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f/lib  /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f/bin
patching script interpreter paths in /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f
checking for references to /build in /nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f...
/nix/store/9yi8dhppzs17kcrwjc8f7j33jqgrfay1-libaosd-0.2.7-9-g177589f

@c0bw3b c0bw3b merged commit f94947f into NixOS:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unode @GrahamcOfBorg @c0bw3b