Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wrapper package for fcitx with plugins. #4839

Merged
merged 1 commit into from Nov 5, 2014

Conversation

cdepillabout
Copy link
Member

This creates a wrapper package for fcitx so that plugins can be enabled by the user. This is based on the wrapper package for pidgin-with-plugins.

By using this wrapper instead of the fcitx package itself, it will be possible for the user to enable/disable plugins.

This is an improvement over #4713 that just makes a wrapper package with the plugins instead of creating an entire new package that must be compiled. This also closes the issue #4550.

This creates a wrapper package for fcitx so that plugins can be enabled
by the user.  This is based on the wrapper package for
pidgin-with-plugins.

By using this wrapper instead of the fcitx package itself, it will be
possible for the user to enable/disable plugins.
@cdepillabout
Copy link
Member Author

Making a wrapper package like this was recommended by Damien on the mailing list:

http://lists.science.uu.nl/pipermail/nix-dev/2014-October/014801.html

@@ -1117,6 +1117,10 @@ let

fcitx-configtool = callPackage ../tools/inputmethods/fcitx/fcitx-configtool.nix { };

fcitx-with-plugins = callPackage ../tools/inputmethods/fcitx/wrapper.nix {
plugins = [ ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about including a set of plugins that make sense for most people? Or is that indeed the null set? 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmertens, I believe it is the null set.

Most of fcitx's plugins enable communication with additional IME libraries. The only plugin currently available is anthy, which enables Japanese input.

There are a couple other commonly used Japanese input plugins, but there are not packages for them yet in Nix. In most cases, it wouldn't really make sense to use them together.

I believe there are also other commonly used plugins for Korean and Chinese, but it also wouldn't make sense to use these plugins together (unless you speak Korean, Chinese, Japanese, etc).

@wmertens
Copy link
Contributor

wmertens commented Nov 5, 2014

Alright, I like it.

wmertens added a commit that referenced this pull request Nov 5, 2014
Create wrapper package for fcitx with plugins.
@wmertens wmertens merged commit e13f15b into NixOS:master Nov 5, 2014
@cdepillabout cdepillabout deleted the fcitx-with-plugins-2 branch December 18, 2014 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants