Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotop: 1.2.9 -> 1.5.0 #48407

Merged
merged 1 commit into from Oct 15, 2018
Merged

gotop: 1.2.9 -> 1.5.0 #48407

merged 1 commit into from Oct 15, 2018

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Package update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@thefloweringash
Copy link
Member Author

This builds for me on NixOS/aarch64 and Darwin, but my attempts on NixOS/x86_64-linux are causing my nix-daemon to spin at 100% cpu.

@xeji
Copy link
Contributor

xeji commented Oct 14, 2018

Let's see what happens on ofborg. I'll also try a local build on x86_64-linux.
@GrahamcOfBorg build gotop

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gotop

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f0y1fqlhy6m3mi4ijfkc7wlqa4fnagnx-gotop-1.5.0-bin
shrinking /nix/store/f0y1fqlhy6m3mi4ijfkc7wlqa4fnagnx-gotop-1.5.0-bin/bin/gotop
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f0y1fqlhy6m3mi4ijfkc7wlqa4fnagnx-gotop-1.5.0-bin/bin
patching script interpreter paths in /nix/store/f0y1fqlhy6m3mi4ijfkc7wlqa4fnagnx-gotop-1.5.0-bin
checking for references to /build in /nix/store/f0y1fqlhy6m3mi4ijfkc7wlqa4fnagnx-gotop-1.5.0-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/f0y1fqlhy6m3mi4ijfkc7wlqa4fnagnx-gotop-1.5.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gotop

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ng3w1jd6q353n2yif541im32mg94j1d4-gotop-1.5.0-bin
shrinking /nix/store/ng3w1jd6q353n2yif541im32mg94j1d4-gotop-1.5.0-bin/bin/gotop
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ng3w1jd6q353n2yif541im32mg94j1d4-gotop-1.5.0-bin/bin
patching script interpreter paths in /nix/store/ng3w1jd6q353n2yif541im32mg94j1d4-gotop-1.5.0-bin
checking for references to /build in /nix/store/ng3w1jd6q353n2yif541im32mg94j1d4-gotop-1.5.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/ng3w1jd6q353n2yif541im32mg94j1d4-gotop-1.5.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gotop

Partial log (click to expand)

find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
find: '/nix/store/myzicm3b1biww0qqr28ivnfbhyq1wgp3-gotop-1.5.0': No such file or directory
/nix/store/9l6yrzmsyb3l95y5xfw2rqw014kynmcb-gotop-1.5.0-bin

@xeji
Copy link
Contributor

xeji commented Oct 14, 2018

builds and runs fine on my local x86_64-linux box.

@xeji
Copy link
Contributor

xeji commented Oct 14, 2018

but my attempts on NixOS/x86_64-linux are causing my nix-daemon to spin at 100% cpu.

Since the build succeeded on two other machines, I'd suspect this is some local issue of your system.

@thefloweringash
Copy link
Member Author

I can no longer reproduce the issue on the two hosts I was testing on.

@xeji xeji merged commit 975c9b5 into NixOS:master Oct 15, 2018
anpryl added a commit to anpryl/nixpkgs that referenced this pull request Oct 17, 2018
@anpryl
Merge branch 'master' of https://github.com/NixOS/nixpkgs
2b0a1be 
* 'master' of https://github.com/NixOS/nixpkgs: (554 commits)
  generators: make toPretty handle floats correctly
  haskell-yesod-core: disable broken test suite
  git-annex: update sha256 hash for the new 6.20181011 version
  cabal2nix: update overrides for latest yaml version
  hackage-packages.nix: automatic Haskell package set update
  hackage2nix: disable failing Hydra builds
  LTS Haskell 12.13
  saga: add mpickering as a co-maintainer after NixOS#39125
  python3Packages.cmd2: 0.9.4 -> 0.9.6
  ghc: add new 8.4.4 version
  apvlv: add .desktop file
  staruml: fix download URL
  spectmorph: init at 0.4.1
  termdown: 1.11.0 -> 1.14.1 (NixOS#48443)
  gotop: 1.2.9 -> 1.5.0 (NixOS#48407)
  emacs-mac: use generic builder
  dolphin-emu: fix metadata (GPLv2 -> GPLv2+, http -> https)
  tests/prometheus-exporters: add new Tor exporter
  dbeaver: 5.2.1 -> 5.2.2
  nixos/hardened: add myself to maintainers
  ...
@thefloweringash thefloweringash deleted the gotop-1.5.0 branch November 4, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @xeji @GrahamcOfBorg