Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bb: add Darwin compatibility #49079

Merged
merged 2 commits into from Oct 29, 2018
Merged

bb: add Darwin compatibility #49079

merged 2 commits into from Oct 29, 2018

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Oct 24, 2018 •
edited

It even has working sound, unlike on Linux!

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@alyssais
libmikmod: remove duplicate libpulseaudio dep
4807e04 
This is already included as a propagatedBuildInput, so no need to have
it also be a buildInput.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bb, libmikmod

Partial log (click to expand)

moving /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/man to /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1
shrinking /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/bin/bb
gzipping man pages under /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/bin
patching script interpreter paths in /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1
checking for references to /build in /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1...
/nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1
/nix/store/vixh3283zjr4c0zsm68zrda31z4fyhg5-libmikmod-3.3.11.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bb, libmikmod

Partial log (click to expand)

moving /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/man to /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1
shrinking /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/bin/bb
gzipping man pages under /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/bin
patching script interpreter paths in /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1
checking for references to /build in /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1...
/nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1
/nix/store/9dsrmcq9yagxxlvg2yxzi6yd9la6hg4m-libmikmod-3.3.11.1

@alyssais
bb: add Darwin compatibility
c49aa0d 
It even has working sound, unlike on Linux!
@LnL7
Copy link
Member

LnL7 commented Oct 29, 2018

@GrahamcOfBorg build bb

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bb

Partial log (click to expand)

 /nix/store/acnfbicd84bnya2l2dq868b5l482qihw-coreutils-8.30/bin/install -c -m 644 ./bb2.s3m /nix/store/kmpxqlibkg4hgcckmibb12dka3xg4l4p-bb-1.3rc1/share/bb/bb2.s3m
 /nix/store/acnfbicd84bnya2l2dq868b5l482qihw-coreutils-8.30/bin/install -c -m 644 ./bb3.s3m /nix/store/kmpxqlibkg4hgcckmibb12dka3xg4l4p-bb-1.3rc1/share/bb/bb3.s3m
make[1]: Leaving directory '/private/tmp/nix-build-bb-1.3rc1.drv-0/bb-1.3.0'
post-installation fixup
moving /nix/store/kmpxqlibkg4hgcckmibb12dka3xg4l4p-bb-1.3rc1/man to /nix/store/kmpxqlibkg4hgcckmibb12dka3xg4l4p-bb-1.3rc1/share/man
gzipping man pages under /nix/store/kmpxqlibkg4hgcckmibb12dka3xg4l4p-bb-1.3rc1/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kmpxqlibkg4hgcckmibb12dka3xg4l4p-bb-1.3rc1/bin
patching script interpreter paths in /nix/store/kmpxqlibkg4hgcckmibb12dka3xg4l4p-bb-1.3rc1
/nix/store/kmpxqlibkg4hgcckmibb12dka3xg4l4p-bb-1.3rc1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bb

Partial log (click to expand)

post-installation fixup
moving /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/man to /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1
shrinking /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/bin/bb
gzipping man pages under /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1/bin
patching script interpreter paths in /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1
checking for references to /build in /nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1...
/nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bb

Partial log (click to expand)

post-installation fixup
moving /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/man to /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1
shrinking /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/bin/bb
gzipping man pages under /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1/bin
patching script interpreter paths in /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1
checking for references to /build in /nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1...
/nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bb, libmikmod

Partial log (click to expand)

/nix/store/45yhpr2wnr3fcyffhs7b5gkvigycmns1-bb-1.3rc1
/nix/store/9dsrmcq9yagxxlvg2yxzi6yd9la6hg4m-libmikmod-3.3.11.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bb, libmikmod

Partial log (click to expand)

/nix/store/m6f9l3r27q2g14rcynlawdyradlyd08f-bb-1.3rc1
/nix/store/vixh3283zjr4c0zsm68zrda31z4fyhg5-libmikmod-3.3.11.1

@LnL7 LnL7 merged commit d80f2db into NixOS:master Oct 29, 2018
@LnL7
Copy link
Member

LnL7 commented Oct 29, 2018

backported in 74fe437

@alyssais alyssais deleted the bb branch November 2, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @GrahamcOfBorg @LnL7 @Mic92