Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easysnap: init at 2018-10-28 #49347

Merged
merged 1 commit into from Nov 2, 2018
Merged

easysnap: init at 2018-10-28 #49347

merged 1 commit into from Nov 2, 2018

Conversation

sjau
Copy link

@sjau sjau commented Oct 28, 2018

Motivation for this change

Adding easysnap to nixpkgs/NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

pkgs/tools/backup/easysnap/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/easysnap/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/easysnap/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/easysnap/default.nix Show resolved Hide resolved
license = licenses.gpl3;
maintainers = with maintainers; [ "sjau" ];
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this empty line.

@lheckemann
Copy link
Member

@GrahamcOfBorg build easysnap

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: easysnap

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: easysnap

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q47jb2mlfv2ncfw4lwwahlbahyssnibh-easysnap-unstable-2018-10-28
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q47jb2mlfv2ncfw4lwwahlbahyssnibh-easysnap-unstable-2018-10-28/bin
patching script interpreter paths in /nix/store/q47jb2mlfv2ncfw4lwwahlbahyssnibh-easysnap-unstable-2018-10-28
/nix/store/q47jb2mlfv2ncfw4lwwahlbahyssnibh-easysnap-unstable-2018-10-28/bin/easysnapRecv: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/q47jb2mlfv2ncfw4lwwahlbahyssnibh-easysnap-unstable-2018-10-28/bin/easysnap: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/q47jb2mlfv2ncfw4lwwahlbahyssnibh-easysnap-unstable-2018-10-28...
/nix/store/q47jb2mlfv2ncfw4lwwahlbahyssnibh-easysnap-unstable-2018-10-28

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: easysnap

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/izlpvl6kxrz6gdm128nn1f03d7wr0qlx-easysnap-unstable-2018-10-28
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/izlpvl6kxrz6gdm128nn1f03d7wr0qlx-easysnap-unstable-2018-10-28/bin
patching script interpreter paths in /nix/store/izlpvl6kxrz6gdm128nn1f03d7wr0qlx-easysnap-unstable-2018-10-28
/nix/store/izlpvl6kxrz6gdm128nn1f03d7wr0qlx-easysnap-unstable-2018-10-28/bin/easysnap: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/izlpvl6kxrz6gdm128nn1f03d7wr0qlx-easysnap-unstable-2018-10-28/bin/easysnapRecv: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/izlpvl6kxrz6gdm128nn1f03d7wr0qlx-easysnap-unstable-2018-10-28...
/nix/store/izlpvl6kxrz6gdm128nn1f03d7wr0qlx-easysnap-unstable-2018-10-28

@lheckemann
Copy link
Member

Mostly LGTM, but the commits need some squashing to get rid of the nasty githubby commit messages. Should I do that?

@lheckemann lheckemann closed this Oct 29, 2018
@lheckemann
Copy link
Member

Whoops misclicked.

@lheckemann lheckemann reopened this Oct 29, 2018
@sjau
Copy link
Author

sjau commented Oct 30, 2018

What squashing?

@sjau
Copy link
Author

sjau commented Oct 31, 2018

Is this going to be merged?

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 1, 2018

@GrahamcOfBorg build easysnap

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: easysnap

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4vb77xmvid41swsj7dndiyydnbbhhdjx-easysnap-unstable-2018-10-28
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4vb77xmvid41swsj7dndiyydnbbhhdjx-easysnap-unstable-2018-10-28/bin
patching script interpreter paths in /nix/store/4vb77xmvid41swsj7dndiyydnbbhhdjx-easysnap-unstable-2018-10-28
/nix/store/4vb77xmvid41swsj7dndiyydnbbhhdjx-easysnap-unstable-2018-10-28/bin/easysnap: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/4vb77xmvid41swsj7dndiyydnbbhhdjx-easysnap-unstable-2018-10-28/bin/easysnapRecv: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/4vb77xmvid41swsj7dndiyydnbbhhdjx-easysnap-unstable-2018-10-28...
/nix/store/4vb77xmvid41swsj7dndiyydnbbhhdjx-easysnap-unstable-2018-10-28

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: easysnap

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xxybglx58fzjmbdd8z3xpdyc97zhsw55-easysnap-unstable-2018-10-28
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xxybglx58fzjmbdd8z3xpdyc97zhsw55-easysnap-unstable-2018-10-28/bin
patching script interpreter paths in /nix/store/xxybglx58fzjmbdd8z3xpdyc97zhsw55-easysnap-unstable-2018-10-28
/nix/store/xxybglx58fzjmbdd8z3xpdyc97zhsw55-easysnap-unstable-2018-10-28/bin/easysnapRecv: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/xxybglx58fzjmbdd8z3xpdyc97zhsw55-easysnap-unstable-2018-10-28/bin/easysnap: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/xxybglx58fzjmbdd8z3xpdyc97zhsw55-easysnap-unstable-2018-10-28...
/nix/store/xxybglx58fzjmbdd8z3xpdyc97zhsw55-easysnap-unstable-2018-10-28

@grahamc
Copy link
Member

grahamc commented Nov 1, 2018

(non-blocking comment) seems like more reasonable for a personal overlay, since it is a small shell-script with the header of "HERE BE DRAGONS". However, since Nixpkgs doesn't have an inclusion / exclusion policy, it is (as noted) a non-blocking comment :)

@lheckemann lheckemann merged commit e23ebd0 into NixOS:master Nov 2, 2018
@lheckemann
Copy link
Member

Thanks!

@lheckemann
Copy link
Member

@grahamc, AFAIU the main reason @sjau made this PR was to be able to share it with other nixos users (like myself) easily.

@sjau sjau deleted the easysnap-init branch November 22, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants