-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python.pkgs.Pyro4: new package (at version 4.74) #49351
Conversation
b4df9cd
to
11cd34f
Compare
pkgs/top-level/python-packages.nix
Outdated
@@ -4684,6 +4684,12 @@ in { | |||
|
|||
Pyro = callPackage ../development/python-modules/pyro { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about removing the old version then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that openopc
uses that :-/
pythonEnv = python.withPackages(ps: [ps.Pyro]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project was updated last in 2015. I will propose the removal from nixpkgs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package was removed.
The project is dead and it blocks the upgrade of Pyro (NixOS#49351)
includes its dependency python.pkgs.serpent (at version 1.27)
11cd34f
to
b7201c5
Compare
@Mic92 pushed another commit which removes |
|
||
selectors34 = callPackage ../development/python-modules/selectors34 { }; | ||
|
||
Pyro4 = callPackage ../development/python-modules/pyro4 { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keeping the Pyro
attribute then instead of renaming it to Pyro4
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah upstream calls it Pyro4
. Should be ok then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right
Success on aarch64-linux (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34 The following builds were skipped because they don't evaluate on aarch64-linux: python27Packages.serpe Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34 The following builds were skipped because they don't evaluate on x86_64-linux: python27Packages.serpe Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34 The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.serpe Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent Partial log (click to expand)
|
Thanks! |
Motivation for this change
I noticed that nixpkgs contains only Pyro Python package, which is obsolete now (see https://pypi.org/project/Pyro/) and Pyro4 should be used instead.
This PR contains a package for Pyro4 including its dependency serpent.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)