Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supercollider: build with alsa (midi) support on non-darwin #49556

Merged
merged 1 commit into from Nov 14, 2018

Conversation

yurkobb
Copy link
Contributor

@yurkobb yurkobb commented Oct 31, 2018

Motivation for this change

MIDI functionality is very important in real time sound synthesis packages like SuperCollider, and other linux distributions build SuperCollider with MIDI support.

Things done

Added alsaLib input on non-darwin, effectively enabling Midi support on Linux.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Fedora)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Midi functionality is kind of core to an environment like SuperCollider.
@Mic92
Copy link
Member

Mic92 commented Nov 1, 2018

cc @magnetophon

@magnetophon
Copy link
Member

lgtm!

@srhb srhb merged commit 8630f58 into NixOS:master Nov 14, 2018
@yurkobb yurkobb deleted the supercollider-alsa-linux branch December 6, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants