Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcurl: init at 1.0.0 #49837

Merged
merged 1 commit into from Nov 7, 2018
Merged

grpcurl: init at 1.0.0 #49837

merged 1 commit into from Nov 7, 2018

Conversation

knl
Copy link
Contributor

@knl knl commented Nov 6, 2018

Motivation for this change

We use this tool daily, it would be nice to have it straight from nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

pkgs/tools/networking/grpcurl/default.nix Outdated Show resolved Hide resolved
@nlewo
Copy link
Member

nlewo commented Nov 7, 2018

@GrahamcOfBorg build grpcurl

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: grpcurl

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/lr9fi3i9029dj500mrz96k80qy6bcs18-grpcurl-1.0.0-bin
shrinking /nix/store/lr9fi3i9029dj500mrz96k80qy6bcs18-grpcurl-1.0.0-bin/bin/bankdemo
shrinking /nix/store/lr9fi3i9029dj500mrz96k80qy6bcs18-grpcurl-1.0.0-bin/bin/testserver
shrinking /nix/store/lr9fi3i9029dj500mrz96k80qy6bcs18-grpcurl-1.0.0-bin/bin/grpcurl
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lr9fi3i9029dj500mrz96k80qy6bcs18-grpcurl-1.0.0-bin/bin
patching script interpreter paths in /nix/store/lr9fi3i9029dj500mrz96k80qy6bcs18-grpcurl-1.0.0-bin
checking for references to /build in /nix/store/lr9fi3i9029dj500mrz96k80qy6bcs18-grpcurl-1.0.0-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/lr9fi3i9029dj500mrz96k80qy6bcs18-grpcurl-1.0.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: grpcurl

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/lfkzd5mlvq3v2c3z9xp11qx5lbgnfbqd-grpcurl-1.0.0-bin
shrinking /nix/store/lfkzd5mlvq3v2c3z9xp11qx5lbgnfbqd-grpcurl-1.0.0-bin/bin/bankdemo
shrinking /nix/store/lfkzd5mlvq3v2c3z9xp11qx5lbgnfbqd-grpcurl-1.0.0-bin/bin/grpcurl
shrinking /nix/store/lfkzd5mlvq3v2c3z9xp11qx5lbgnfbqd-grpcurl-1.0.0-bin/bin/testserver
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lfkzd5mlvq3v2c3z9xp11qx5lbgnfbqd-grpcurl-1.0.0-bin/bin
patching script interpreter paths in /nix/store/lfkzd5mlvq3v2c3z9xp11qx5lbgnfbqd-grpcurl-1.0.0-bin
checking for references to /build in /nix/store/lfkzd5mlvq3v2c3z9xp11qx5lbgnfbqd-grpcurl-1.0.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/lfkzd5mlvq3v2c3z9xp11qx5lbgnfbqd-grpcurl-1.0.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: grpcurl

Partial log (click to expand)

find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
find: '/nix/store/xmjdvda4v21lrgmrd7yk9mg3q0ncki5i-grpcurl-1.0.0': No such file or directory
/nix/store/jnkp797y0hbpwx7ghi30cc4kcj7hp8zm-grpcurl-1.0.0-bin

@nlewo
Copy link
Member

nlewo commented Nov 7, 2018

Thanks!

@nlewo nlewo merged commit ea0b564 into NixOS:master Nov 7, 2018
@knl knl deleted the add-grpcurl branch November 7, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants